Skip to content

improve for loops #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hduelme wants to merge 1 commit into
base: master
Choose a base branch
from
Open

improve for loops #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions dht11/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,7 @@ def __parse_data_pull_up_lengths(self, data):
lengths = [] # will contain the lengths of data pull up periods
current_length = 0 # will contain the length of the previous period

for i in range(len(data)):

current = data[i]
for current in data:
current_length += 1

if state == STATE_INIT_PULL_DOWN:
Expand Down Expand Up @@ -173,26 +171,16 @@ def __calculate_bits(self, pull_up_lengths):

# use the halfway to determine whether the period it is long or short
halfway = shortest_pull_up + (longest_pull_up - shortest_pull_up) / 2
bits = []

for i in range(0, len(pull_up_lengths)):
bit = False
if pull_up_lengths[i] > halfway:
bit = True
bits.append(bit)

return bits
return [pull_up > halfway for pull_up in pull_up_lengths]

def __bits_to_bytes(self, bits):
the_bytes = []
byte = 0

for i in range(0, len(bits)):
for i, bit in enumerate(bits):
byte = byte << 1
if (bits[i]):
byte = byte | 1
else:
byte = byte | 0
byte |= bit
if ((i + 1) % 8 == 0):
the_bytes.append(byte)
byte = 0
Expand Down