Skip to content

Do not use superglobals #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Do not use superglobals #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a289c8
Do not use superglobals
szepeviktor Mar 28, 2024
0549b17
fix comments
szepeviktor Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion PSR12NeutronRuleset/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,10 +274,10 @@
<severity>5</severity>
<type>warning</type>
</rule>
<!-- https://github.com/szepeviktor/uninformative-words -->
<rule ref="PSR12NeutronRuleset.NamingConventions.MeaningfulVariableName">
<properties>
<property name="forbiddenNames" type="array">
<!-- https://github.com/szepeviktor/uninformative-words -->
<element key="arr" value="Provide more context"/>
<element key="bool" value="Provide more context"/>
<element key="boolean" value="Provide more context"/>
Expand Down Expand Up @@ -312,6 +312,16 @@
<element key="value" value="Provide more context"/>
<element key="var" value="Provide more context"/>
<element key="vdata" value="Provide more context"/>
<!-- https://www.php.net/manual/en/language.variables.superglobals.php -->
<element key="GLOBALS" value="Do not use superglobals"/>
<element key="_SERVER" value="Do not use superglobals"/>
<element key="_GET" value="Do not use superglobals"/>
<element key="_POST" value="Do not use superglobals"/>
<element key="_FILES" value="Do not use superglobals"/>
<element key="_COOKIE" value="Do not use superglobals"/>
<element key="_SESSION" value="Do not use superglobals"/>
<element key="_REQUEST" value="Do not use superglobals"/>
<element key="_ENV" value="Do not use superglobals"/>
</property>
</properties>
</rule>
Expand Down