Remove WP_CLI::error from earlyTerminatingMethodCalls config

[lipemat]

WP_CLI::error supports an $exit parameter to disable terminating.

Fixes: #213

[szepeviktor]

Thank you!

[szepeviktor]

@johnbillion Will it be a nicer day with this change?

[johnbillion]

I don't think this is right approach because the method terminates by default. It needs to be a conditional rule based on the value of the $exit parameter.

[szepeviktor]

@lipemat Could you make John's wish come true?
I think it needs a PHPStan extension.

[lipemat]

Ideally we would remove both WP_CLI: from earlyTerminatingMethodCalls in this extension in favor of having the proper @return types in the WP_CLI stubs.

We have an effort to add proper types happening over here. Until the earlyTerminatingMethodCalls are removed from the phpstan-wordpress extension, the new @phpstan-return type will not work.

[lipemat]

The proper types made it into the main branch on wp-cli.

[szepeviktor]

Very nice.
I merge this one.

Let's hope the Internet won't blow up!