Open
Conversation
if an error occurs in the DB controller JSON deserialization, the raw frame content is logged
Owner
|
This is handled by TCPController.cs lines 159 - did you have a case when RawTCPFrame was improper JSON ? |
Contributor
Author
|
Yes I did ; don’t you remember the problem we had with a pilot who had a single quote in his call sign ?
Le 28 févr. 2021 à 11:52 +0100, Szymon Porwolik <notifications@github.com>, a écrit :
… This is handled by TCPController.cs lines 159 - did you have a case when RawTCPFrame was improper JSON ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Owner
|
Well this shall not happen anymore - SRS data is serialized in , so if there is a problem we shall catch this inBut, anyhow those changes are good - I will merge those into v0.12.1 didn't want to change v0.12.0 as it was tested recently and wanted to push it to release. |
Contributor
Author
|
Hi @szporwolik ! Any release coming soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a try-catch block around the deserialization of the JSON TCP frame, which catches the errors and logs both a message and the raw frame.