Skip to content

Manage JSON deserialize exception#58

Open
davidp57 wants to merge 1 commit intoszporwolik:devfrom
VEAF:dev-manage-json-deserialize-exception
Open

Manage JSON deserialize exception#58
davidp57 wants to merge 1 commit intoszporwolik:devfrom
VEAF:dev-manage-json-deserialize-exception

Conversation

@davidp57
Copy link
Contributor

I added a try-catch block around the deserialization of the JSON TCP frame, which catches the errors and logs both a message and the raw frame.

if an error occurs in the DB controller JSON
deserialization, the raw frame content is logged
@szporwolik
Copy link
Owner

This is handled by TCPController.cs lines 159 - did you have a case when RawTCPFrame was improper JSON ?

@davidp57
Copy link
Contributor Author

davidp57 commented Feb 28, 2021 via email

@szporwolik
Copy link
Owner

Well this shall not happen anymore -

ClientName = rgx.Replace(ClientName, "");

SRS data is serialized in

ExtSRSJson = JsonConvert.SerializeObject(raw_dcssrs);
, so if there is a problem we shall catch this in
catch (Exception exc_srs)

But, anyhow those changes are good - I will merge those into v0.12.1 didn't want to change v0.12.0 as it was tested recently and wanted to push it to release.

@davidp57
Copy link
Contributor Author

Hi @szporwolik ! Any release coming soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants