Open
Conversation
msk-nkhr
force-pushed
the
add-retry-to-postToSlack
branch
7 times, most recently
from
8c74536 to
c43f3bd
Compare
msk-nkhr
commented
Feb 20, 2024
| working_directory: ~/digdag-slack | ||
| docker: | ||
| - image: openjdk:8u141-jdk | ||
| - image: cimg/openjdk:8.0.402 |
Author
There was a problem hiding this comment.
openjdk:8u141-jdk was added Let's Encrypt certificates ( https://www.java.com/download/help/release_changes.html ).
However, that CA had already expired, so an error occurs as below ( https://letsencrypt.org/docs/dst-root-ca-x3-expiration-september-2021/)
curl performs SSL certificate verification by default, using a "bundle"
of Certificate Authority (CA) public keys (CA certs). If the default
bundle file isn't adequate, you can specify an alternate file
using the --cacert option.
If this HTTPS server uses a certificate signed by a CA represented in
the bundle, the certificate verification probably failed due to a
problem with the certificate (it might be expired, or the name might
not match the domain name in the URL).
If you'd like to turn off curl's verification of the certificate, use
the -k (or --insecure) option.
I modified to use the latest cimg/open-jdk8 instead of openjdk:8u141-jdk.
msk-nkhr
force-pushed
the
add-retry-to-postToSlack
branch
5 times, most recently
from
6643a04 to
bc03ffc
Compare
This reverts commit 1eab18c.
msk-nkhr
force-pushed
the
add-retry-to-postToSlack
branch
from
3adc448 to
d3d4354
Compare
Author
|
@szyn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue
In rare cases, 429 or 503 errors occur and posting to Slack is failed, but the
slack>:task succeeds.Error messages as below.
I want to retry when responce code is retryable.
Moreover I want to make slack task failed if posting to Slack is failed.
modification
how to retry
According to the official okhttp document , Interceptors are explained as bellow.
I created Interceptor class for retrying, and registered it by calling addInterceptor() on OkHttpClient.Builder.
test error
commit: 0ba2663
testing post to slack(circle ci): https://app.circleci.com/pipelines/github/szyn/digdag-slack/43/workflows/9c070197-d48b-4a37-a3be-7e8c37da8d5c/jobs/92
I checked to failed
slack>:task and retrying post to slack when posting to slack was failed.Also, you can control a setting of retry by using
_errorparameter.Log
other
cicle ci
openjdk:8u141-jdk was added Let's Encrypt certificates ( https://www.java.com/download/help/release_changes.html ).
However, that CA had already expired, so an error occurs as below ( https://letsencrypt.org/docs/dst-root-ca-x3-expiration-september-2021/)
I modified to use the latest cimg/open-jdk8 instead of openjdk:8u141-jdk.