Skip to content

fix: apply skipValidation to all presets when set on parent#326

Merged
juliusmarminge merged 5 commits intot3-oss:mainfrom
Abdalrhman-Almarakeby:fix/inherit-skip-validation
Dec 15, 2025
Merged

fix: apply skipValidation to all presets when set on parent#326
juliusmarminge merged 5 commits intot3-oss:mainfrom
Abdalrhman-Almarakeby:fix/inherit-skip-validation

Conversation

@Abdalrhman-Almarakeby
Copy link
Copy Markdown
Contributor

Previously, presets ignored the parent’s skipValidation flag, requiring manual setup. This fix makes them inherit it automatically.

fixes #323.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
t3-env ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 0:20am

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 28, 2025

@Abdalrhman-Almarakeby is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@OreQr
Copy link
Copy Markdown

OreQr commented Mar 29, 2025

Maybe make all customization options like this

@Abdalrhman-Almarakeby
Copy link
Copy Markdown
Contributor Author

Maybe make all customization options like this

skipValidation makes the most sense to work this way. anyone would expect it to skip validation for presets too (see #323). But at the end, it's up to the maintainers.

@Abdalrhman-Almarakeby Abdalrhman-Almarakeby force-pushed the fix/inherit-skip-validation branch from 95ac8fc to 46dea00 Compare December 4, 2025 16:52
@juliusmarminge juliusmarminge added this pull request to the merge queue Dec 15, 2025
Merged via the queue into t3-oss:main with commit 5987d5a Dec 15, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extended configurations do not respect skipValidation

3 participants