Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@mmikhan is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
I think we need to ship #316 before to support client/shared presets |
|
Any update on this? @juliusmarminge this is basically making the vite preset irrelevant if you are building a vite SPA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing Vite's
servervariables tosharedvariables. Vite seems exposes all the built-inimport.meta.envconstants o both client and server side (tested as well).Thanks to @dylanhu7 for noticing this in the original PR 🙏.
With this change, all the built-in constants exposed by Vite shall available in both dev and client side without requiring any client side prefix.
Note
Couldn't figure out why the typecheck is failing 😕