Code quality improvements and Go 1.18+ modernization #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the switch statement in parseError from a boolean expression to a direct value match for improved readability and maintainability. Moved the default case inside the switch block.
Changed variadic parameter type from 'interface{}' to 'any' in logger and debugger functions for improved Go 1.18+ compatibility and clarity.
Standardized error messages by removing trailing periods for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains three small but meaningful improvements to the codebase:
Changes
parseError- Simplified the switch statement from using boolean expressions (case errno == -1:) to direct value matching (case -1:), which is more idiomatic and improves readability. Also moved the default case inside the switch block.interface{}withany- Updated variadic parameters in logger functions frominterface{}toanyfor better readability and alignment with Go 1.18+ conventions. Theanytype alias is semantically identical but more concise.golint).Motivation
These changes improve code consistency and follow Go best practices without introducing any breaking changes or behavioral modifications. All changes are purely cosmetic/stylistic.