Updated tests for FakeTableTests.class.sql to better align with TDD practices; added a new extended property tSQLt.IsTempObject for table test double; changed the name of the original extended property from tSQLt.FakeTable_OrgTableName to tSQLt.Private_TestDouble_OrgObjectName

Author: lizbaron

Experiments/NameResolutionResearch.sql

@@ -180,7 +180,7 @@ tSQLt.FakeTable
    EXEC (@cmd);
 
    EXEC sys.sp_addextendedproperty 
-   @name = N'tSQLt.FakeTable_OrgTableName', 
+   @name = N'tSQLt.Private_TestDouble_OrgObjectName', 
    @value = @newName, 
    @level0type = N'SCHEMA', @level0name = @schemaName, -- <use tSQLt.private_getCleanSchemaName>
    @level1type = N'TABLE',  @level1name = @tableName; -- <use tSQLt.[private_getCleanObjectName]>
@@ -210,7 +210,7 @@ tSQLt.ApplyConstraint
    WHERE class_desc = 'OBJECT_OR_COLUMN'
      AND major_id = OBJECT_ID(@schemaName + '.' + @tableName) -- <use tSQLt.private_GetQuotedFullName>
      AND minor_id = 0
-     AND name = 'tSQLt.FakeTable_OrgTableName';
+     AND name = 'tSQLt.Private_TestDouble_OrgObjectName';
 
   SELECT @cmd = 'CONSTRAINT ' + name + ' CHECK' + definition 
     FROM sys.check_constraints

Source/ApplyConstraint_Methods.sql

@@ -23,7 +23,7 @@ RETURN
         ON newtbl.object_id = p.major_id
        AND p.minor_id = 0
        AND p.class_desc = 'OBJECT_OR_COLUMN'
-       AND p.name = 'tSQLt.FakeTable_OrgTableName'
+       AND p.name = 'tSQLt.Private_TestDouble_OrgObjectName'
         ON OBJECT_NAME(constraints.parent_object_id) = CAST(p.value AS NVARCHAR(4000))
        AND constraints.schema_id = newtbl.schema_id
        AND constraints.object_id = @ConstraintObjectId;

Source/BuildOrder.txt

@@ -68,7 +68,7 @@ tSQLt.Private_GetDefaultConstraintDefinition.sfn.sql
 tSQLt.Private_GetUniqueConstraintDefinition.sfn.sql
 tSQLt.Private_CreateFakeTableStatement.sfn.sql
 tSQLt.Private_CreateFakeOfTable.ssp.sql
-tSQLt.Private_MarkFakeTable.ssp.sql
+tSQLt.Private_MarktSQLtTempObject.ssp.sql
 tSQLt.FakeTable.ssp.sql
 tSQLt.Private_GenerateCreateProcedureSpyStatement.ssp.sql
 tSQLt.Private_CreateProcedureSpy.ssp.sql

Source/Source.ssmssqlproj

@@ -2,7 +2,6 @@
 <SqlWorkbenchSqlProject xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema" Name="Source">
   <Items>
     <LogicalFolder Name="Connections" Type="2" Sorted="true">
-      <Items />
     </LogicalFolder>
     <LogicalFolder Name="Queries" Type="0" Sorted="true">
       <Items>
@@ -390,11 +389,11 @@
           <AssociatedConnUserName />
           <FullPath>tSQLt.Private_ListTestAnnotations.sfn.sql</FullPath>
         </FileNode>
-        <FileNode Name="tSQLt.Private_MarkFakeTable.ssp.sql">
+        <FileNode Name="tSQLt.Private_MarktSQLtTempObject.ssp.sql">
           <AssociatedConnectionMoniker />
           <AssociatedConnSrvName />
           <AssociatedConnUserName />
-          <FullPath>tSQLt.Private_MarkFakeTable.ssp.sql</FullPath>
+          <FullPath>tSQLt.Private_MarktSQLtTempObject.ssp.sql</FullPath>
         </FileNode>
         <FileNode Name="tSQLt.Private_MarkObjectBeforeRename.ssp.sql">
           <AssociatedConnectionMoniker />

Source/tSQLt.FakeTable.ssp.sql

@@ -49,7 +49,7 @@ BEGIN
 
    EXEC tSQLt.Private_CreateFakeOfTable @SchemaName, @TableName, @OrigTableFullName, @Identity, @ComputedColumns, @Defaults;
 
-   EXEC tSQLt.Private_MarkFakeTable @SchemaName, @TableName, @NewNameOfOriginalTable;
+   EXEC tSQLt.Private_MarktSQLtTempObject @SchemaName, @TableName, @NewNameOfOriginalTable;
 END
 ---Build-
 GO

Source/tSQLt.Private_GetForeignKeyDefinition.sfn.sql

@@ -79,7 +79,7 @@ RETURN SELECT 'CONSTRAINT ' + name + ' FOREIGN KEY (' +
                  CROSS APPLY tSQLt.Private_GetForeignKeyParColumns(k.object_id) AS parCol
                  CROSS APPLY tSQLt.Private_GetForeignKeyRefColumns(k.object_id) AS refCol
                  LEFT JOIN sys.extended_properties e
-                   ON e.name = 'tSQLt.FakeTable_OrgTableName'
+                   ON e.name = 'tSQLt.Private_TestDouble_OrgObjectName'
                   AND e.value = OBJECT_NAME(k.referenced_object_id)
                  JOIN sys.tables refTab
                    ON COALESCE(e.major_id,k.referenced_object_id) = refTab.object_id

Source/tSQLt.Private_MarkFakeTable.ssp.sql renamed to Source/tSQLt.Private_MarktSQLtTempObject.ssp.sql

@@ -1,7 +1,7 @@
-IF OBJECT_ID('tSQLt.Private_MarkFakeTable') IS NOT NULL DROP PROCEDURE tSQLt.Private_MarkFakeTable;
+IF OBJECT_ID('tSQLt.Private_MarktSQLtTempObject') IS NOT NULL DROP PROCEDURE tSQLt.Private_MarktSQLtTempObject;
 GO
 ---Build+
-CREATE PROCEDURE tSQLt.Private_MarkFakeTable
+CREATE PROCEDURE tSQLt.Private_MarktSQLtTempObject
   @SchemaName NVARCHAR(MAX),
   @TableName NVARCHAR(MAX),
   @NewNameOfOriginalTable NVARCHAR(4000)
@@ -11,7 +11,13 @@ BEGIN
    DECLARE @UnquotedTableName NVARCHAR(MAX);SET @UnquotedTableName = OBJECT_NAME(OBJECT_ID(@SchemaName+'.'+@TableName));
 
    EXEC sys.sp_addextendedproperty 
-      @name = N'tSQLt.FakeTable_OrgTableName', 
+      @name = N'tSQLt.IsTempObject',
+      @value = 1, 
+      @level0type = N'SCHEMA', @level0name = @UnquotedSchemaName, 
+      @level1type = N'TABLE',  @level1name = @UnquotedTableName;   
+
+   EXEC sys.sp_addextendedproperty 
+      @name = N'tSQLt.Private_TestDouble_OrgObjectName', 
       @value = @NewNameOfOriginalTable, 
       @level0type = N'SCHEMA', @level0name = @UnquotedSchemaName, 
       @level1type = N'TABLE',  @level1name = @UnquotedTableName;

Source/tSQLt.class.sql

@@ -266,7 +266,7 @@ BEGIN
    WHERE class_desc = 'OBJECT_OR_COLUMN'
      AND major_id = OBJECT_ID(@SchemaName + '.' + @TableName)
      AND minor_id = 0
-     AND name = 'tSQLt.FakeTable_OrgTableName');
+     AND name = 'tSQLt.Private_TestDouble_OrgObjectName');
 END;
 GO
 
@@ -279,7 +279,7 @@ AS
    WHERE class_desc = 'OBJECT_OR_COLUMN'
      AND major_id = @TableObjectId
      AND minor_id = 0
-     AND name = 'tSQLt.FakeTable_OrgTableName';
+     AND name = 'tSQLt.Private_TestDouble_OrgObjectName';
 GO
 
 

Source/testoutput.sql

@@ -95,7 +95,7 @@ RETURN SELECT 'CONSTRAINT ' + name + ' FOREIGN KEY (' +
                    ON refCol.object_id = c.referenced_object_id
                   AND refCol.column_id = c.referenced_column_id
                  LEFT JOIN sys.extended_properties e
-                   ON e.name = 'tSQLt.FakeTable_OrgTableName'
+                   ON e.name = 'tSQLt.Private_TestDouble_OrgObjectName'
                   AND e.value = OBJECT_NAME(c.referenced_object_id)
                  JOIN sys.tables refTab
                    ON COALESCE(e.major_id,refCol.object_id) = refTab.object_id

Tests/FakeTableTests.class.sql

@@ -17,52 +17,49 @@
 EXEC tSQLt.NewTestClass 'FakeTableTests';
 GO
 
-CREATE PROC FakeTableTests.AssertTableIsNewObjectThatHasNoConstraints
-@TableName NVARCHAR(MAX)
+CREATE PROC FakeTableTests.AssertTableIsNewObjectThatHasNoChildObjects
+@TableName NVARCHAR(MAX),
+@OriginalObjectId INT
 AS
 BEGIN
-  DECLARE @OldTableObjectId INT;
-
   IF OBJECT_ID(@TableName) IS NULL
     EXEC tSQLt.Fail 'Table ',@TableName,' does not exist!';
-
-  SELECT @OldTableObjectId = OBJECT_ID(QUOTENAME(OBJECT_SCHEMA_NAME(major_id))+'.'+QUOTENAME(CAST(value AS NVARCHAR(4000))))
-  FROM sys.extended_properties WHERE major_id = OBJECT_ID(@TableName) and name = 'tSQLt.FakeTable_OrgTableName'
-
-  IF @OldTableObjectId IS NULL
-    EXEC tSQLt.Fail 'Table ',@TableName,' is not a fake table!';
 
-  IF OBJECT_ID(@TableName) = @OldTableObjectId
+  IF OBJECT_ID(@TableName) = @OriginalObjectId
     EXEC tSQLt.Fail 'Table ',@TableName,' is not a new object!';
 
-  SELECT QUOTENAME(OBJECT_SCHEMA_NAME(object_id))+'.'+QUOTENAME(OBJECT_NAME(object_id)) ReferencingObjectName 
-  INTO #actual FROM sys.objects WHERE parent_object_id = OBJECT_ID(@TableName);
-  
-  SELECT TOP(0) * INTO #expected FROM #actual;
+  SELECT QUOTENAME(OBJECT_SCHEMA_NAME(object_id))+'.'+QUOTENAME(OBJECT_NAME(object_id)) ReferencingObjectName, type_desc 
+  INTO #ChildObjects FROM sys.objects WHERE parent_object_id = OBJECT_ID(@TableName);
 
-  EXEC tSQLt.AssertEqualsTable '#expected','#actual','Unexpected referencing objects found!';
+  EXEC tSQLt.AssertEmptyTable @TableName = '#ChildObjects', @Message = 'Unexpected child objects found!';
 END
 GO
 
 CREATE PROC FakeTableTests.[test FakeTable works with 2 part names in first parameter]
 AS
 BEGIN
   CREATE TABLE FakeTableTests.TempTable1(i INT);
+  DECLARE @OriginalObjectId INT = OBJECT_ID('FakeTableTests.TempTable1');
 
   EXEC tSQLt.FakeTable 'FakeTableTests.TempTable1';
 
-  EXEC FakeTableTests.AssertTableIsNewObjectThatHasNoConstraints 'FakeTableTests.TempTable1';
+  EXEC FakeTableTests.AssertTableIsNewObjectThatHasNoChildObjects
+    @TableName = 'FakeTableTests.TempTable1',
+    @OriginalObjectId = @OriginalObjectId;
 END;
 GO
 
 CREATE PROC FakeTableTests.[test FakeTable takes 2 nameless parameters containing schema and table name]
 AS
 BEGIN
   CREATE TABLE FakeTableTests.TempTable1(i INT);
+  DECLARE @OriginalObjectId INT = OBJECT_ID('FakeTableTests.TempTable1');
 
   EXEC tSQLt.FakeTable 'FakeTableTests','TempTable1';
 
-  EXEC FakeTableTests.AssertTableIsNewObjectThatHasNoConstraints 'FakeTableTests.TempTable1';
+  EXEC FakeTableTests.AssertTableIsNewObjectThatHasNoChildObjects
+    @TableName = 'FakeTableTests.TempTable1',
+    @OriginalObjectId = @OriginalObjectId;  
 END;
 GO
 
@@ -161,11 +158,9 @@ CREATE PROC FakeTableTests.[test a faked table has no primary key]
 AS
 BEGIN
   CREATE TABLE FakeTableTests.TempTable1(i INT PRIMARY KEY);
-  
+    
   EXEC tSQLt.FakeTable 'FakeTableTests.TempTable1';
 
-  EXEC FakeTableTests.AssertTableIsNewObjectThatHasNoConstraints 'FakeTableTests.TempTable1';
-  
   INSERT INTO FakeTableTests.TempTable1 (i) VALUES (1);
   INSERT INTO FakeTableTests.TempTable1 (i) VALUES (1);
 END;
@@ -178,7 +173,6 @@ BEGIN
 
   EXEC tSQLt.FakeTable 'FakeTableTests.TempTable1';
 
-  EXEC FakeTableTests.AssertTableIsNewObjectThatHasNoConstraints 'FakeTableTests.TempTable1';
   INSERT INTO FakeTableTests.TempTable1 (i) VALUES (5);
 END;
 GO
@@ -187,11 +181,10 @@ CREATE PROC FakeTableTests.[test a faked table has no foreign keys]
 AS
 BEGIN
   CREATE TABLE FakeTableTests.TempTable0(i INT PRIMARY KEY);
-  CREATE TABLE FakeTableTests.TempTable1(i INT REFERENCES FakeTableTests.TempTable0(i));
+  CREATE TABLE FakeTableTests.TempTable1(i INT REFERENCES FakeTableTests.TempTable0(i));  
 
   EXEC tSQLt.FakeTable 'FakeTableTests.TempTable1';
-  
-  EXEC FakeTableTests.AssertTableIsNewObjectThatHasNoConstraints 'FakeTableTests.TempTable1';
+      
   INSERT INTO FakeTableTests.TempTable1 (i) VALUES (5);
 END;
 GO
@@ -203,12 +196,9 @@ BEGIN
 
   EXEC tSQLt.FakeTable 'FakeTableTests.TempTable1';
 
-  EXEC FakeTableTests.AssertTableIsNewObjectThatHasNoConstraints 'FakeTableTests.TempTable1';
   INSERT INTO FakeTableTests.TempTable1 (i) DEFAULT VALUES;
 
-  DECLARE @value INT;
-  SELECT @value = i
-    FROM FakeTableTests.TempTable1;
+  DECLARE @value INT = (SELECT i FROM FakeTableTests.TempTable1);
 
   EXEC tSQLt.AssertEquals NULL, @value;
 END;
@@ -221,7 +211,6 @@ BEGIN
 
   EXEC tSQLt.FakeTable 'FakeTableTests.TempTable1';
 
-  EXEC FakeTableTests.AssertTableIsNewObjectThatHasNoConstraints 'FakeTableTests.TempTable1';
   INSERT INTO FakeTableTests.TempTable1 (i) VALUES (1);
   INSERT INTO FakeTableTests.TempTable1 (i) VALUES (1);
 END;
@@ -235,7 +224,6 @@ BEGIN
 
   EXEC tSQLt.FakeTable 'FakeTableTests.TempTable1';
 
-  EXEC FakeTableTests.AssertTableIsNewObjectThatHasNoConstraints 'FakeTableTests.TempTable1';
   INSERT INTO FakeTableTests.TempTable1 (i) VALUES (1);
   INSERT INTO FakeTableTests.TempTable1 (i) VALUES (1);
 END;
@@ -248,7 +236,6 @@ BEGIN
 
   EXEC tSQLt.FakeTable 'FakeTableTests.TempTable1';
 
-  EXEC FakeTableTests.AssertTableIsNewObjectThatHasNoConstraints 'FakeTableTests.TempTable1';
   INSERT INTO FakeTableTests.TempTable1 (i) VALUES (NULL);
 END;
 GO
@@ -1014,28 +1001,57 @@ AS
 BEGIN
   CREATE TABLE FakeTableTests.TempTable1(i INT NOT NULL);
 
+  DECLARE @OriginalObjectId INT = OBJECT_ID('FakeTableTests.TempTable1');
+    
   EXEC tSQLt.FakeTable '[FakeTableTests]','[TempTable1]';
 
-  EXEC FakeTableTests.AssertTableIsNewObjectThatHasNoConstraints 'FakeTableTests.TempTable1';
+  EXEC FakeTableTests.AssertTableIsNewObjectThatHasNoChildObjects
+    @TableName = 'FakeTableTests.TempTable1',
+    @OriginalObjectId = @OriginalObjectId;
 
 END;
 GO
-
---CREATE PROC FakeTableTests.[test FakeTable works with cross database synonym]
---AS
---BEGIN
---  CREATE TABLE tempdb.dbo.TempTable1(i INT NOT NULL);
---  CREATE SYNONYM FakeTableTests.TempTable1 FOR tempdb.dbo.TempTable1
+CREATE PROC FakeTableTests.[test new FakeTable is marked as tSQLt.IsTempObject]
+AS
+BEGIN
+  CREATE TABLE FakeTableTests.TempTable1(i INT NOT NULL);
 
---  EXEC tSQLt.FakeTable '[FakeTableTests]','[TempTable1]';
+  EXEC tSQLt.FakeTable 'FakeTableTests.TempTable1';
 
---  EXEC FakeTableTests.AssertTableIsNewObjectThatHasNoConstraints 'FakeTableTests.TempTable1';
-
---END;
---GO
+  SELECT name, value 
+    INTO #Actual
+    FROM sys.extended_properties
+   WHERE class_desc = 'OBJECT_OR_COLUMN'
+     AND major_id = OBJECT_ID('FakeTableTests.TempTable1')
+     AND name = 'tSQLt.IsTempObject';
 
+  SELECT TOP(0) A.* INTO #Expected FROM #Actual A RIGHT JOIN #Actual X ON 1=0;
+  
+  INSERT INTO #Expected VALUES('tSQLt.IsTempObject',	1);
 
+  EXEC tSQLt.AssertEqualsTable '#Expected','#Actual';
+END;
+GO
+CREATE PROC FakeTableTests.[test new FakeTable is marked with tSQLt.Private_TestDouble_OrgObjectName]
+AS
+BEGIN
+  CREATE TABLE FakeTableTests.TempTable1(i INT NOT NULL);
+  DECLARE @OriginalObjectId INT = OBJECT_ID('FakeTableTests.TempTable1');
+  
+  EXEC tSQLt.FakeTable 'FakeTableTests.TempTable1';
+  
+  SELECT name, value 
+    INTO #Actual
+    FROM sys.extended_properties
+   WHERE class_desc = 'OBJECT_OR_COLUMN'
+     AND major_id = OBJECT_ID('FakeTableTests.TempTable1')
+     AND name = 'tSQLt.Private_TestDouble_OrgObjectName';
 
+  SELECT TOP(0) A.* INTO #Expected FROM #Actual A RIGHT JOIN #Actual X ON 1=0;
+  
+  INSERT INTO #Expected VALUES('tSQLt.Private_TestDouble_OrgObjectName',	OBJECT_NAME(@OriginalObjectId));
 
---ROLLBACK
+  EXEC tSQLt.AssertEqualsTable '#Expected','#Actual';
+END;
+GO