Skip to content

Conversation

@Kybxd
Copy link
Collaborator

@Kybxd Kybxd commented Jan 8, 2026

  • compiler: use filepath.Rel to make the path of protoFiles relative to protoPaths.
  • protogen: ProtoInputOption.ProtoFiles accepts glob patterns relative to current working directory (consistent with confgen).
  • protogen/confgen: all imports must be explicitly specified by InputOption.ProtoFiles, which guarantees predefined files not to import generated files.

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.13%. Comparing base (2fe0c0a) to head (8e7bf97).

Files with missing lines Patch % Lines
internal/x/xproto/protoc/compiler.go 86.36% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
- Coverage   75.14%   75.13%   -0.01%     
==========================================
  Files          85       85              
  Lines        8570     8579       +9     
==========================================
+ Hits         6440     6446       +6     
- Misses       1564     1566       +2     
- Partials      566      567       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants