Skip to content

Comments

refactor: structure#146

Merged
Gusarich merged 7 commits intomainfrom
structural-refactor
Nov 30, 2025
Merged

refactor: structure#146
Gusarich merged 7 commits intomainfrom
structural-refactor

Conversation

@Gusarich
Copy link
Member

closes #119

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

def add_strategy_args(parser: argparse.ArgumentParser) -> None:
from ..strategies import AVAILABLE_STRATEGIES

P0 Badge CLI strategy args import points to missing module

Calling add_strategy_args() now tries to import ..strategies.AVAILABLE_STRATEGIES, but after the package move there is no pitaya.strategies module (only pitaya.orchestration.strategy). Invoking the CLI entrypoint runs create_parser(), which calls this function and immediately raises ModuleNotFoundError, preventing any pitaya command from starting. Update the import to reference the new strategy package so the parser can be built.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Gusarich
Copy link
Member Author

@codex review this PR extremely carefully. it's a huge refactor here. focus on bugs, correctness, logic and behavior. make sure nothing is broken and all documentation/readmes/cli docs and everything in general is consistent and aligned with refactored module structure.

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Gusarich Gusarich merged commit 6cc6d7d into main Nov 30, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Structure refactor

1 participant