Skip to content

feat: polish doc-review strategy#36

Merged
Gusarich merged 4 commits intomainfrom
doc-review-strategy-refinement
Aug 29, 2025
Merged

feat: polish doc-review strategy#36
Gusarich merged 4 commits intomainfrom
doc-review-strategy-refinement

Conversation

@Gusarich
Copy link
Copy Markdown
Member

closes #28

@Gusarich Gusarich added this to the 0.2.0 milestone Aug 26, 2025
@Gusarich Gusarich force-pushed the doc-review-strategy-refinement branch 3 times, most recently from 67047b3 to f11f0e7 Compare August 28, 2025 13:48
@Gusarich Gusarich force-pushed the doc-review-strategy-refinement branch from f11f0e7 to 1d98a34 Compare August 29, 2025 04:58
@Gusarich
Copy link
Copy Markdown
Member Author

@codex review!

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

async def execute(
self,
prompt: str,
base_branch: str,
ctx: "StrategyContext",
) -> List[InstanceResult]:

[P1] Preserve user prompt in reviewer prompts

The strategy still accepts a prompt argument but never uses it when building reviewer or validator prompts, whereas the previous version injected the original request into _build_reviewer_prompt. As a result the caller’s instructions (e.g. pitaya "Review docs for X" --strategy doc-review …) are silently ignored and the agents always receive the built‑in generic prompt. This removes the operator’s ability to scope or customize the review and can lead to incorrect or incomplete reports. Consider threading the user prompt back into the reviewer prompt or otherwise documenting that the argument is unused.


Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

@Gusarich Gusarich merged commit 3edd1c0 into main Aug 29, 2025
2 checks passed
@Gusarich Gusarich deleted the doc-review-strategy-refinement branch August 29, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Polish Documentation Review strategy

1 participant