Skip to content

Don't build (Haskell) benchmarks by default, use cabal bench#119

Merged
sajith merged 4 commits intotahoe-lafs:masterfrom
LeastAuthority:dont-build-benchmark-by-default
May 2, 2025
Merged

Don't build (Haskell) benchmarks by default, use cabal bench#119
sajith merged 4 commits intotahoe-lafs:masterfrom
LeastAuthority:dont-build-benchmark-by-default

Conversation

@hacklschorsch
Copy link
Member

@hacklschorsch hacklschorsch commented Mar 6, 2025

Building the benchmark suite by default broke the tahoe-lafs-mobile build since its criterion can't be built with the android version of GHC.

Also, building the benchmark takes ages.

Use cabal build --enable-benchmark to build the benchmark from now on, and cabal bench to run the benchmark (like specified in the Cabal documentation).

This broke the tahoe-lafs-mobile build since its criterion
can't be built with the android version of GHC.

Use `cabal build --enable-benchmark` to build the
benchmark from now on.
@hacklschorsch hacklschorsch changed the title Don't build benchmarks by default Don't build (Haskell) benchmarks by default, use cabal bench Mar 6, 2025
@hacklschorsch
Copy link
Member Author

Hey @meejah can we merge this?

@hacklschorsch
Copy link
Member Author

Or who could be interested in this - @sajith?

Copy link
Member

@sajith sajith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the deal with the CI failures here? Is upload-artifact@v3 too old?

@hacklschorsch
Copy link
Member Author

What is the deal with the CI failures here? Is upload-artifact@v3 too old?

Yes, that's what #121 is for - happy if you can take a look there as well!

@sajith
Copy link
Member

sajith commented Mar 17, 2025

Yes, that's what #121 is for - happy if you can take a look there as well!

I approved #121. Are you able to merge it, or should I do that?

@hacklschorsch
Copy link
Member Author

hacklschorsch commented Mar 17, 2025 via email

@hacklschorsch
Copy link
Member Author

hacklschorsch commented Apr 3, 2025

This is CI green apart from publishing on test PyPI - Maybe the CI needs a tiny bit of tweaking to actually not publish pull requests on test pypi @sajith?

https://github.com/tahoe-lafs/zfec/actions/runs/14239893166/job/39907563248?pr=119

The workflow context indicates that this action was called from a
pull request on a fork. GitHub doesn't give these workflows OIDC permissions,
even if id-token: write is explicitly configured.

To fix this, change your publishing workflow to use an event that
forks of your repository cannot trigger (such as tag or release
creation, or a manually triggered workflow dispatch).

@hacklschorsch
Copy link
Member Author

Hey @sajith ! Please hit the merge button on this PR, I don't have the privilege. (The one red CI item is because of #133 I believe)

@sajith sajith merged commit d61431a into tahoe-lafs:master May 2, 2025
47 of 48 checks passed
@sajith
Copy link
Member

sajith commented May 2, 2025

@hacklschorsch Done! Sorry about not being around much.

@hacklschorsch hacklschorsch deleted the dont-build-benchmark-by-default branch May 15, 2025 13:09
@hacklschorsch
Copy link
Member Author

Thanks @sajith and no worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants