Don't build (Haskell) benchmarks by default, use cabal bench#119
Conversation
This broke the tahoe-lafs-mobile build since its criterion can't be built with the android version of GHC. Use `cabal build --enable-benchmark` to build the benchmark from now on.
cabal bench
|
Hey @meejah can we merge this? |
|
Or who could be interested in this - @sajith? |
sajith
left a comment
There was a problem hiding this comment.
What is the deal with the CI failures here? Is upload-artifact@v3 too old?
Yes, that's what #121 is for - happy if you can take a look there as well! |
|
Please do it when you get to it, no hurries. (I don't have the necessary permission)
|
|
This is CI green apart from publishing on test PyPI - Maybe the CI needs a tiny bit of tweaking to actually not publish pull requests on test pypi @sajith? https://github.com/tahoe-lafs/zfec/actions/runs/14239893166/job/39907563248?pr=119
|
|
@hacklschorsch Done! Sorry about not being around much. |
|
Thanks @sajith and no worries! |
Building the benchmark suite by default broke the tahoe-lafs-mobile build since its
criterioncan't be built with the android version of GHC.Also, building the benchmark takes ages.
Use
cabal build --enable-benchmarkto build the benchmark from now on, andcabal benchto run the benchmark (like specified in the Cabal documentation).