Open
Conversation
5eb2833 to
2a04d20
Compare
Author
|
@taiki-e this is not done, but does it look like a good direction to explore further? |
69bcef2 to
566baff
Compare
1436eb2 to
a23e1dd
Compare
Owner
|
Thanks for the PR and sorry for the late response! I haven't reviewed this in detail, but it looks like a good direction! |
e172f19 to
93840f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm opening this PR now to get some early feedback on the direction.
This currently supports invocations like this one:
At the moment, the
--releaseand--targetflags are required forllvm-covto find the right object files: fuzzers are built with--releaseby default, and the artifacts are stored intarget/<host target>/releaseby default.The output of That command looks like this:
Some argument parsing questions
llvm-cov fuzz-coveragealso enable--releaseby default? or warn when it's not specifiedllvm-cov fuzz-coveragealso enable--target <host target>by default? or warn when it's not specifiedIn both cases, the arguments to
fuzz coveragecould pick something non-default. So the proper way to do this is to parse the arguments. That's fragile, though I don't expectcargo-fuzzto make radical changes.Alternatively, we could ask for some sort of
--jsonoutput tocargo fuzz coveragethat has the relevant information.Some open questions
fuzz coveragewith those, right?linking #415