Add support for build-dir layout v2#483
Conversation
| let mut collect_target_dir = | ||
| |mut target_dir: Utf8PathBuf, mut build_dir: Option<Utf8PathBuf>| -> Result<()> { |
There was a problem hiding this comment.
Sorry about the diffs in this closure, I don't really understand why rustfmt has decided it wants to change this.
The only real change is adding both regexes to the walk_target_dir fn call
walk_target_dir(cx, &build_script_v1_layout_re, &build_script_v2_layout_re, &target_dir)There was a problem hiding this comment.
hiding the whitespace changes in GitHub makes reviewing this a bit easier
3c32be8 to
25117e3
Compare
taiki-e
left a comment
There was a problem hiding this comment.
Thanks for the PR! It looks good aside from the fact that I can't tell if it's actually working since there's no test.
008cf8d to
96d23cb
Compare
|
I added a test. I didn't know exactly how the test harness works so let me know if I did something wrong. Before committing I modified the |
This PR adds logic to handle the new layout of Cargo's
build-dirwhich changes the directory structure of Cargo internally.(can be enabled with
-Zbuild-dir-new-layout)While this is still unstable we are not expecting any large changes to the structure at this point.
Resources