Skip to content

fix(rawdb): add hexutil.Bytes marshaling override for L1Origin.Signature#534

Merged
davidtaikocha merged 1 commit intotaikoxyz:taikofrom
jmadibekov:jmadibekov/fix-api
Feb 25, 2026
Merged

fix(rawdb): add hexutil.Bytes marshaling override for L1Origin.Signature#534
davidtaikocha merged 1 commit intotaikoxyz:taikofrom
jmadibekov:jmadibekov/fix-api

Conversation

@jmadibekov
Copy link

Problem

#531 changed the signature's RPC API to use hex but missed updating the struct-level marshaling used by gencodec. That is, the the signature field was missing a JSON marshaling override, causing it to serialize as a number array (which is Go's default encoding) instead of a hex string.

This breaks Nethermind client, we discovered that from the tests failing in the NMC PR: NethermindEth/nethermind#10625. When L1Origin is embedded inside PayloadAttributes for engine_forkchoiceUpdatedV3, Nethermind returns "Invalid params" because it can't parse the number array format and expects the hex string by the Ethereum convention.

Changes

  • Add Signature hexutil.Bytes to l1OriginMarshaling
  • Regenerate generated files via go generate ./...

Copy link
Collaborator

@davidtaikocha davidtaikocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidtaikocha davidtaikocha merged commit 01dfc26 into taikoxyz:taiko Feb 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants