fix(rawdb): add hexutil.Bytes marshaling override for L1Origin.Signature#534
Merged
davidtaikocha merged 1 commit intotaikoxyz:taikofrom Feb 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#531 changed the signature's RPC API to use hex but missed updating the struct-level marshaling used by gencodec. That is, the the signature field was missing a JSON marshaling override, causing it to serialize as a number array (which is Go's default encoding) instead of a hex string.
This breaks Nethermind client, we discovered that from the tests failing in the NMC PR: NethermindEth/nethermind#10625. When
L1Originis embedded insidePayloadAttributesforengine_forkchoiceUpdatedV3, Nethermind returns "Invalid params" because it can't parse the number array format and expects the hex string by the Ethereum convention.Changes
Signature hexutil.Bytestol1OriginMarshalinggo generate ./...