Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes bridge pause checks actually block execution.
Several bridge flows were calling
isBridgePaused().then(...), which does not gate the current async flow and can throw outside localtry/catch. That means paused-state checks could be bypassed in practice.I replaced those call sites with awaited guards (
if (await isBridgePaused()) ...) in the bridge/approval paths and used early returns in UI handlers where throwing would become an unhandled async error.I also added explicit
BridgePausedErrorhandling inhandleBridgeError, so paused-state failures show a clear paused message instead of falling back to a generic unknown error.