Skip to content

Conversation

@Sammy-T
Copy link
Contributor

@Sammy-T Sammy-T commented Aug 20, 2025

The table content on the 'help' page overflows on small screens. This allows it to scroll so it doesn't affect the rest of the page.

The table content overflows on small screens. This allows it to scroll so it doesn't affect the rest of the page.

Signed-off-by: Sammy-T <[email protected]>
@mikeodr
Copy link
Contributor

mikeodr commented Aug 20, 2025

Approved, thanks First-time contributor!

Copy link
Member

@willnorris willnorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Sammy-T, thanks for the patch. I'm actually having trouble reproducing the overflow issue on a mobile device or narrow desktop browser window. Would you mind sharing what browser and device you're seeing this on, and maybe a screenshot?

I'll probably also have you switch to use the class name used by Tailwind, the CSS framework that we use for golink. (Basically just overflow-auto instead of of overflow, then run yarn run build:css and it will auto-generate the base.css file)

@Sammy-T
Copy link
Contributor Author

Sammy-T commented Aug 20, 2025

Sure. I initially noticed it on my phone's (Samsung s22) Chrome browser. It appears to affect Chromium browsers since I can't reproduce it on Firefox on desktop but a similar issue does appear on Chrome and Brave when using the device toolbar to shrink the view.

You can see the gap between where the rest of the page content ends and where the table is pushing out in this screenshot from my desktop browser:

Screenshot 2025-08-20 143526

@Sammy-T Sammy-T requested a review from willnorris August 20, 2025 19:06
Copy link
Member

@willnorris willnorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, thanks! I was having trouble reproducing it, but that's because I was using Firefox. Trying chromium with the devtools panel easily reproduced it. LGTM

@willnorris willnorris merged commit b54cbbb into tailscale:main Aug 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants