Skip to content

Conversation

@Sammy-T
Copy link
Contributor

@Sammy-T Sammy-T commented Oct 19, 2025

This just updates go dependencies.

@willnorris
Copy link
Member

willnorris commented Oct 20, 2025

it looks like you did a full go get -u ? That moves the indirect dependencies past whatever versions are defined in https://github.com/tailscale/tailscale, which we generally try not to do unless there is a specific reason to, since those are the versions that get the most testing.

Bumping the direct dependencies, and then running go mod tidy to pull in the indirect dependencies should be fine. I'll probably go ahead and do that here.

@willnorris willnorris force-pushed the deps branch 2 times, most recently from 04a1002 to e365cca Compare October 20, 2025 01:15
@willnorris willnorris force-pushed the deps branch 5 times, most recently from b3fd780 to fd1baa6 Compare October 20, 2025 01:59
Signed-off-by: Sammy-T <[email protected]>
@willnorris
Copy link
Member

I tried to get the nix build working. I really did. I updated the version of Go in the flake file, but the test complained about only finding go1.25rc2. I tried updating the version of go installed on the action runner. I updated the version of the nix action we're using. I give up. I'm not going to block merging PRs on fixing these flakes. It's just not worth the time.

/cc @grahamc since I'm sure you'll know exactly what's wrong

@willnorris willnorris merged commit 42765de into tailscale:main Oct 20, 2025
3 of 4 checks passed
@Sammy-T
Copy link
Contributor Author

Sammy-T commented Oct 20, 2025

it looks like you did a full go get -u ? That moves the indirect dependencies past whatever versions are defined in https://github.com/tailscale/tailscale, which we generally try not to do unless there is a specific reason to, since those are the versions that get the most testing.

Bumping the direct dependencies, and then running go mod tidy to pull in the indirect dependencies should be fine. I'll probably go ahead and do that here.

Yep, that's what I did. I intended to update the Tailscale dependency but figured "while I'm here I might as well just do a general update". Sorry, I didn't know it would be a concern. I'll try to remember that should it come up again. Thanks.

@willnorris
Copy link
Member

no biggie, thanks for doing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants