Skip to content

Conversation

yagil
Copy link
Contributor

@yagil yagil commented Jan 20, 2025

Adds a way to enable a funnel from libtailscale.

@bradfitz
Copy link
Member

Can you squash your commits in the branch together, down to 1 commit?

@bradfitz bradfitz changed the title Add tailscale_enable_funnel to tailscale.h Add tailscale_enable_funnel_to_localhost_plaintext_http1 to tailscale.h Jan 20, 2025
@bradfitz
Copy link
Member

@raggi, you cool with this API and name?

This gets it out of the way of something more general, like sent in #28.

@yagil
Copy link
Contributor Author

yagil commented Jan 20, 2025

Can you squash your commits in the branch together, down to 1 commit?

done

@raggi
Copy link
Member

raggi commented Jan 20, 2025

@raggi, you cool with this API and name?

This gets it out of the way of something more general, like sent in #28.

Yeah absolutely. We might want to take a struct approach, but we'd then need to decide about the whole enum ffi debacle. This SGTM.

@bradfitz
Copy link
Member

Please squash. We have "Squash & Merge" disabled on this repo.

@yagil
Copy link
Contributor Author

yagil commented Jan 21, 2025

Please squash. We have "Squash & Merge" disabled on this repo.

Done

@bradfitz bradfitz merged commit 9d45e58 into tailscale:main Jan 21, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants