fix: use the user-set device name before falling back to the device model #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odel Signed-off-by: Amaan Qureshi <[email protected]>
amaanq
force-pushed
the
fix-device-name
branch
from
94af349 to
00c38f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I recently acquired a new phone and decided to run Tailscale on it. I was a bit surprised to see the device name was rather than the actual device name I had set in android settings. I think that it would be better to use this by default, and fall back to the model name if querying for the device name fails.
Solution
In this PR I added a simple query for the device's name, if that's not null we return that, otherwise we continue with the old logic of using the device model. I also renamed the function to
getDeviceNameas that's more appropriate now.