Handle Missing Devices and Enforce Recreation on device_id Change for tailscale_device_subnet_routes #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bdalpe thank you for the PR! Are you able to squash your commits and adjust the resulting commit message to follow https://github.com/tailscale/tailscale/blob/main/docs/commit-messages.md? The DCO failure can be resolved by doing a |
bdalpe
force-pushed
the
bug/526-resource-subnets
branch
from
099d5f6 to
2878650
Compare
…eSubnetRoutesRead Reset resource id to force recreation when resourceDeviceSubnetRoutesRead receives a 404 status code Fixes tailscale#526 Signed-off-by: Brendan Dalpe <[email protected]>
bdalpe
force-pushed
the
bug/526-resource-subnets
branch
from
2878650 to
a6ac885
Compare
|
Hey @mpminardi, this should be fixed now. Let me know if you need any other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR improves the resource
tailscale_device_subnet_routesbehavior in two key ways:Force Resource Recreation on device_id Change
Added
ForceNew: trueto thedevice_idschema field to ensure the resource is recreated when the device ID changes.Graceful Handling of Missing Devices
Updated
resourceDeviceSubnetRoutesReadto check for a 404 response from the API. If the device no longer exists, the resource ID is cleared to allow Terraform to recreate it instead of failing the plan.Which issue this PR fixes (use
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged):Fixes #526
Special notes for your reviewer: N/A