Skip to content

Test against Prettier v3.6 #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 3, 2025
+20 −12
Merged

Test against Prettier v3.6 #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f9223b4
Bump Prettier to v3.6
thecrypticace Jul 1, 2025
2e7c494
Tweak plugin detection
thecrypticace Jul 1, 2025
851c297
Enable test
thecrypticace Jul 1, 2025
894a08e
Bump JSDoc
thecrypticace Jul 3, 2025
d261401
fix check
thecrypticace Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,11 @@
"marko": "^5.31.18",
"postcss": "^8.4.35",
"postcss-import": "^16.0.1",
"prettier": "^3.2",
"prettier": "^3.6",
"prettier-plugin-astro": "^0.12.2",
"prettier-plugin-css-order": "^2.0.0",
"prettier-plugin-import-sort": "^0.0.7",
"prettier-plugin-jsdoc": "^1.0.1",
"prettier-plugin-jsdoc": "^1.3.3",
"prettier-plugin-marko": "^3.1.1",
"prettier-plugin-multiline-arrays": "^3.0.6",
"prettier-plugin-organize-attributes": "^1.0.0",
Expand Down
7 changes: 7 additions & 0 deletions src/plugins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,13 @@ export async function loadPlugins() {
let path = maybeResolve(name)

for (let plugin of options.plugins) {
if (plugin instanceof URL) {
if (plugin.protocol !== 'file:') continue
if (plugin.hostname !== '') continue

plugin = plugin.pathname
}

if (typeof plugin === 'string') {
if (plugin === name || plugin === path) {
return mod
Expand Down
3 changes: 1 addition & 2 deletions tests/tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,7 @@ export let tests: Record<string, TestEntry[]> = {
// TODO: Enable this test — it causes console noise but not a failure
// t`<div [ngClass]="{ '${no}': foo && definitely&a:syntax*error }" class="${yes}"></div>`,

// TODO: Enable test once we can run all tests against Prettier v3.6
// t`<div [ngClass]="\`${yes}\`"></div>`,
t`<div [ngClass]="\`${yes}\`"></div>`,
],
css: [...css, t`@apply ${yes} !important;`],
scss: [
Expand Down