Fix whitespace removal inside nested concat and template expressions #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
approved these changes
Sep 2, 2025
tests/tests.ts
Outdated
| [ | ||
| `<div [ngClass]="' flex ' + ' underline ' + ' block '"></div>`, | ||
| `<div [ngClass]="'flex ' + ' underline' + ' block'"></div>`, | ||
| `<div [ngClass]="'flex ' + ' underline ' + ' block'"></div>`, |
There was a problem hiding this comment.
Maybe we can add an additional test with some whitespace in the middle.
[
`<div [ngClass]="' flex ' + ' italic underline ' + ' block '"></div>`,
`<div [ngClass]="' flex ' + ' italic underline ' + ' block '"></div>`,
]Just to ensure that we are still taking care of whitespace in the middle where it's safe?
There was a problem hiding this comment.
Technically there's a lot more cases where it's safe to drop these but that requires a more complex "understanding" of the AST.
There was a problem hiding this comment.
Updated the test 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #328
Fixes #337
Fixes #305