Skip to content

Fix template literal whitespace collapse for adjacent quasis #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecrypticace merged 2 commits into from
Dec 24, 2025
Merged

Fix template literal whitespace collapse for adjacent quasis #427

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1464d10
Fix template literal whitespace collapse for adjacent quasis
Dunqing Dec 24, 2025
8b8df16
Update changelog
thecrypticace Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,7 @@ function canCollapseWhitespaceIn(path: Path<import('@babel/types').Node, any>) {
let nodeEnd = entry.node.end ?? null

for (let quasi of entry.parent.quasis) {
let quasiStart = quasi.end ?? null
let quasiStart = quasi.start ?? null
Copy link
Contributor

@thecrypticace thecrypticace Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol 🤦‍♂️

let quasiEnd = quasi.end ?? null

if (nodeStart !== null && quasiEnd !== null && nodeStart - quasiEnd <= 2) {
Expand Down
8 changes: 8 additions & 0 deletions tests/format.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,14 @@ describe('whitespace', () => {
expect(result).toEqual(";<div className={`header${isExtendable ? ' header-extendable' : ''}`} />")
})

test('whitespace is not trimmed before template literal quasis without leading space', async ({ expect }) => {
let result = await format(";<div className={`${foo ? 'sm:p-0 p-0 ' : ''}header`}></div>", {
parser: 'babel',
})

expect(result).toEqual(";<div className={`${foo ? 'p-0 sm:p-0 ' : ''}header`}></div>")
})

test('duplicate classes are dropped', async ({ expect }) => {
let result = await format('<div class="underline line-through underline flex"></div>')

Expand Down