Skip to content

Bump precision of evaluated calc expressions #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2025
Merged

Bump precision of evaluated calc expressions #1449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3232213
Bump precision of evaluated calc expressions
thecrypticace Sep 2, 2025
6942b82
Update changelog
thecrypticace Sep 2, 2025
5571177
Fix tests
thecrypticace Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/tailwindcss-language-server/tests/completions/completions.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,7 @@ withFixture('v4/basic', (c) => {
'```css',
'.text-sm {',
' font-size: var(--text-sm) /* 0.875rem = 8.75px */;',
' line-height: var(--tw-leading, var(--text-sm--line-height) /* calc(1.25 / 0.875) ≈ 1.4286 */);',
' line-height: var(--tw-leading, var(--text-sm--line-height) /* calc(1.25 / 0.875) ≈ 1.428571 */);',
'}',
'```',
].join('\n'),
Expand Down
9 changes: 8 additions & 1 deletion packages/tailwindcss-language-service/src/util/rewriting/calc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,14 @@ export function evaluateExpression(str: string): string | null {
randomSeed: 1,

// Limit precision to keep values environment independent
precision: 4,
//
// This is mostly to limit displayed numbers to a reasonable length. Ideally
// we could perform any calcs with "infinite" precision and only then round
// numbers back for display purposes.
//
// This is short of the 7 digits that 32-bit floats provide. JS does store
// numbers as doubles so maybe this can be bumped to like 12–15?
precision: 6,
})

// The result array is the same shape as the original so we're guaranteed to
Expand Down
10 changes: 9 additions & 1 deletion packages/tailwindcss-language-service/src/util/rewriting/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,18 @@ test('Evaluating CSS calc expressions', () => {
)

expect(replaceCssCalc('calc(1.25 / 0.875)', (node) => evaluateExpression(node.value))).toBe(
'1.4286',
'1.428571',
)

expect(replaceCssCalc('calc(1/4 * 100%)', (node) => evaluateExpression(node.value))).toBe('25%')

expect(replaceCssCalc('calc(0.12345rem * 0.5)', (node) => evaluateExpression(node.value))).toBe(
'0.061725rem',
)

expect(
replaceCssCalc('calc(0.12345789rem * 0.5)', (node) => evaluateExpression(node.value)),
).toBe('0.061729rem')
})

test('Inlining calc expressions using the design system', () => {
Expand Down
1 change: 1 addition & 0 deletions packages/vscode-tailwindcss/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- Suggest default variant values when they also support arbitrary values ([#1439](https://github.com/tailwindlabs/tailwindcss-intellisense/pull/1439))
- Show color swatches for OKLCH colors with units in all positions ([#1442](https://github.com/tailwindlabs/tailwindcss-intellisense/pull/1442))
- Fix incorrect diagnostic for `--theme(--some-var inline)` ([#1443](https://github.com/tailwindlabs/tailwindcss-intellisense/pull/1443))
- Bump precision of evaluated calc expressions ([#1449](https://github.com/tailwindlabs/tailwindcss-intellisense/pull/1449))

## 0.14.26

Expand Down