Fix infinite recursion in theme variable lookups #1473
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1463
We'll have to bail in some cases that we didn't before to fix this. This seems fine though. The core problem was that given this theme:
We'd see this CSS:
And we'd try to replace variables in
calc(var(--radius))
. This doesn't start with a var(…) so our recursion guards didn't catch this.This entire system is a bit fragile and I'll be working to clean this up along with how we handle pixel equivalents, light-dark replacements, color-mix replacements, etc… in some future PRs (#1330 is one of those but I want to reorganize + tweak some code first in an earlier PR which will make that one "nicer")