Skip to content

Fix: Remove iOS Safari dialog max-width/max-height constraints in Preflight #19364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Remove iOS Safari dialog max-width/max-height constraints in Preflight #19364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/tailwindcss/preflight.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,15 @@ input:where([type='button'], [type='reset'], [type='submit']),
height: auto;
}

/*
Remove default max-width and max-height constraints on dialog elements in iOS Safari.
*/

dialog {
max-width: none;
max-height: none;
}

/*
Make elements with the HTML hidden attribute stay hidden by default.
*/
Expand Down
10 changes: 10 additions & 0 deletions packages/tailwindcss/tests/ui.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1472,6 +1472,16 @@ test('conic mask color can be changed on hover', async ({ page }) => {
]).toContain(await getPropertyValue('#x', 'mask-image'))
})

test('dialog elements have max-width and max-height reset by Preflight', async ({ page }) => {
let { getPropertyValue } = await render(
page,
html`<dialog id="x">Hello world</dialog>`,
)

expect(await getPropertyValue('#x', 'max-width')).toEqual('none')
expect(await getPropertyValue('#x', 'max-height')).toEqual('none')
})

test("::backdrop can receive a border with just the 'border' utility", async ({ page }) => {
let { getPropertyValue } = await render(
page,
Expand Down