-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Add text-align and text-transform to inherited properties of button, input, etc.
#19369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ton`, `input`, etc.
WalkthroughThe preflight CSS file for Tailwind CSS is updated to include two additional inheritance properties for form control elements. The modifications add Pre-merge checks✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (2)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This is definitely breaking changes (almost any change to Preflight is). For example, in this UI the buttons will now be aligned incorrectly and be uppercase: https://play.tailwindcss.com/5L25lT02oc This is obviously a contrived example and maybe more real world impact would be smaller but it's definitely still a breaking change. I don't think we'd want to do either of these things (personally I'd definitely not want |
Summary
This could be considered a bug fix, because
text-alignandtext-transformusually inherit like those other "font styles" that are reset by Preflight on some elements (button,input, etc.) due to being set to a fixed value by user agent stylesheets. It seems like an oversight.Test plan
Pray this is not a breaking change?