Skip to content

Non-issue: allow user to custom "go" command in makefile#146

Open
hidehalo wants to merge 2 commits intotalent-plan:coursefrom
hidehalo:makefile
Open

Non-issue: allow user to custom "go" command in makefile#146
hidehalo wants to merge 2 commits intotalent-plan:coursefrom
hidehalo:makefile

Conversation

@hidehalo
Copy link
Copy Markdown
Contributor

TinySQL require "go" version 1.13.

I can't install go@1.13 via "Homebrew" on my laptop, cauz it's abandoned at upstream.

Since that, I must download go@1.13 manually from "go" website.

The point is, a lots user work on go version > 1.13, they must have multiple go versions executable command.

We should allow user to custom "go" command in "Makefile".

eg:

# which go@1.13
go@1.13 version
go version go1.13.15 darwin/amd64

# which go@1.18
go version
go version go1.18.3 darwin/amd64

# env variable `GOCMD` use `go@1.13` replace to `go@1.18`
GOCMD=go@1.13 make test-proj1
cd tablecodec && \
	go@1.13 test

# no specific `GOCMD` is fine, we would use default command "go"
 make test-proj1
 cd tablecodec && \
	go test

@hidehalo
Copy link
Copy Markdown
Contributor Author

@winoros @yanguwan PTAL, thx!

@yanguwan yanguwan requested a review from rebelice November 25, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant