Fix checkbox / switch fields invalid state#35
Closed
ldaspt wants to merge 1 commit intotales-from-a-dev:mainfrom
Closed
Fix checkbox / switch fields invalid state#35ldaspt wants to merge 1 commit intotales-from-a-dev:mainfrom
ldaspt wants to merge 1 commit intotales-from-a-dev:mainfrom
Conversation
|
just as a follow up, I have overridden the thanks a lot |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the custom form theme block
checkbox_radio_label, the field validity is incorrectly determined usingform.parent.vars.valid. This checks the validity of the entire parent form, not the individual field.Fix #31
❌ Current behavior
{% if checked and form.parent.vars.valid == false %} {% set valid = false %} {% endif %}Even if the current field has no validation error, it is marked as invalid if any other field in the parent form is invalid.
✅ Expected behavior
The validity check should be scoped to the current field only.
🛠️ Impact
This causes incorrect error styling on checkbox or radio labels, even when they are valid, as soon as any unrelated form field fails validation.