fix(req): do not merge set-cookie response headers #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for the PR! I've merged it in #242 to exclude the change to |
mwhitworth
reviewed
Apr 23, 2025
| @@ -1,2 +1,2 @@ | |||
| elixir 1.13.0 | |||
Collaborator
There was a problem hiding this comment.
The intention here is to support versions as early as possible, to keep the library compatible with as many versions of Elixir and OTP as possible. I'll add a comment to that effect.
Contributor
Author
|
Awesome, thanks for getting this one merged in! This would be another great one to get merged in since it makes the req adapter pretty unusable if the request might take longer than 5s: #239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #240