Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps SpacetimeDSL from version 0.12.0 to 0.13.0, upgrading the SpacetimeDB dependency from 1.6.0 to 1.9.0. It also adds test examples demonstrating that SpacetimeDSL is not available in #[spacetimedb::view] functions and documents this limitation in the README.
Key changes:
- Upgraded SpacetimeDB dependency from 1.6.0 to 1.9.0 across all workspace crates
- Added documentation clarifying SpacetimeDSL's unavailability in view functions due to context struct differences
- Added example view functions to the test suite demonstrating the limitation
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Updated main crate version to 0.13.0 and SpacetimeDB dependency to 1.9.0 |
| derive/Cargo.toml | Updated derive crate version to 0.13.0 and internal dependency references |
| derive-input/Cargo.toml | Updated derive-input crate version to 0.13.0 and SpacetimeDB dependency to 1.9.0 |
| examples/test/Cargo.toml | Updated test example version to 0.13.0 and dependencies to match |
| examples/blackholio/Cargo.toml | Updated blackholio example version to 0.13.0 and dependencies to match |
| examples/test/src/lib.rs | Added example view functions demonstrating SpacetimeDSL limitation with ViewContext and AnonymousViewContext |
| README.md | Documented limitation that SpacetimeDSL doesn't work in view functions due to struct-based contexts |
| Cargo.lock | Updated lockfile with new dependency versions and transitive dependencies (serde, serde_json, etc.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.