Skip to content

fix: scalar theme and bump to 1.30#224

Merged
jplatte merged 3 commits intotamasfe:masterfrom
abbudao:fix-scalar-theme
Jun 4, 2025
Merged

fix: scalar theme and bump to 1.30#224
jplatte merged 3 commits intotamasfe:masterfrom
abbudao:fix-scalar-theme

Conversation

@abbudao
Copy link
Copy Markdown
Contributor

@abbudao abbudao commented May 29, 2025

The pull request #191, that bumped Scalar version to 1.25.118, was merged but didn't address the breaking changes on custom themes that #142 addressed. This PR backports that change while also bumping Scalar to latest.

Copy link
Copy Markdown
Collaborator

@jplatte jplatte May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub doesn't let me review this in the web UI >_>
… and I guess reviewing the minified diff locally isn't gonna be much easier.

Is there an official place I can grab the right file(s) from?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! The scalar bundle can be found on their CDN:

https://cdn.jsdelivr.net/npm/@scalar/api-reference

And that CDN reference can be found on their npm docs: https://www.npmjs.com/package/@scalar/api-reference

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a different header when checking out the version you upgraded to and decided to just pull the latest version.

@jplatte jplatte merged commit 948f984 into tamasfe:master Jun 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants