Merge pull request crossplane#6273 from sttts/sttts-engine-unlock

jbw976 · web-flow · commit 316e84059e8e · 2025-02-06T12:51:50.000-08:00
engine: fix misplaced Unlock
diff --git a/internal/engine/engine.go b/internal/engine/engine.go
@@ -268,7 +268,6 @@ func (e *ControllerEngine) Stop(ctx context.Context, name string) error {
 	// Stop the controller's watches.
 	for wid, w := range c.sources {
 		if err := w.Stop(ctx); err != nil {
-			c.mx.Unlock()
 			return errors.Wrapf(err, "cannot stop %q watch for %q", wid.Type, wid.GVK)
 		}
 		delete(c.sources, wid)

Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,6 @@ func (e *ControllerEngine) Stop(ctx context.Context, name string) error {`
`268`	`268`	`// Stop the controller's watches.`
`269`	`269`	`for wid, w := range c.sources {`
`270`	`270`	`if err := w.Stop(ctx); err != nil {`
`271`		`- c.mx.Unlock()`
`272`	`271`	`return errors.Wrapf(err, "cannot stop %q watch for %q", wid.Type, wid.GVK)`
`273`	`272`	`}`
`274`	`273`	`delete(c.sources, wid)`