Improve error when trying to install an 'empty' dependency

This could happen if you add a dependency to package metadata with all
of the pointer fields unset.

Signed-off-by: Nic Cope <[email protected]>

Author: negz

internal/controller/pkg/resolver/reconciler.go

@@ -589,16 +589,16 @@ func NewPackage(dep *v1beta1.Dependency, version string, ref name.Reference) (*u
 		pack.SetAPIVersion(*dep.APIVersion)
 		pack.SetKind(*dep.Kind)
 	case ptr.Deref(dep.Type, "") == v1beta1.ConfigurationPackageType:
-		pack.SetAPIVersion("pkg.crossplane.io/v1")
-		pack.SetKind("Configuration")
+		pack.SetAPIVersion(v1.ConfigurationGroupVersionKind.GroupVersion().String())
+		pack.SetKind(v1.ConfigurationKind)
 	case ptr.Deref(dep.Type, "") == v1beta1.ProviderPackageType:
-		pack.SetAPIVersion("pkg.crossplane.io/v1")
-		pack.SetKind("Provider")
+		pack.SetAPIVersion(v1.ProviderGroupVersionKind.GroupVersion().String())
+		pack.SetKind(v1.ProviderKind)
 	case ptr.Deref(dep.Type, "") == v1beta1.FunctionPackageType:
-		pack.SetAPIVersion("pkg.crossplane.io/v1")
-		pack.SetKind("Function")
+		pack.SetAPIVersion(v1.FunctionGroupVersionKind.GroupVersion().String())
+		pack.SetKind(v1.FunctionKind)
 	default:
-		return nil, errors.Errorf("cannot determine dependency type - you must specify either a valid type, or an explicit apiVersion and kind")
+		return nil, errors.Errorf("encountered an invalid dependency: package dependencies must specify either a valid type, or an explicit apiVersion, kind, and package")
 	}
 
 	return pack, nil
@@ -613,16 +613,16 @@ func NewPackageList(dep *v1beta1.Dependency) (*unstructured.UnstructuredList, er
 		l.SetAPIVersion(*dep.APIVersion)
 		l.SetKind(*dep.Kind + "List")
 	case ptr.Deref(dep.Type, "") == v1beta1.ConfigurationPackageType:
-		l.SetAPIVersion("pkg.crossplane.io/v1")
-		l.SetKind("ConfigurationList")
+		l.SetAPIVersion(v1.ConfigurationGroupVersionKind.GroupVersion().String())
+		l.SetKind(v1.ConfigurationKind + "List")
 	case ptr.Deref(dep.Type, "") == v1beta1.ProviderPackageType:
-		l.SetAPIVersion("pkg.crossplane.io/v1")
-		l.SetKind("ProviderList")
+		l.SetAPIVersion(v1.ProviderGroupVersionKind.GroupVersion().String())
+		l.SetKind(v1.ProviderKind + "List")
 	case ptr.Deref(dep.Type, "") == v1beta1.FunctionPackageType:
-		l.SetAPIVersion("pkg.crossplane.io/v1")
-		l.SetKind("FunctionList")
+		l.SetAPIVersion(v1.FunctionGroupVersionKind.GroupVersion().String())
+		l.SetKind(v1.FunctionKind + "List")
 	default:
-		return nil, errors.Errorf("cannot determine dependency type - you must specify either a valid type, or an explicit apiVersion and kind")
+		return nil, errors.Errorf("encountered an invalid dependency: package dependencies must specify either a valid type, or an explicit apiVersion, kind, and package")
 	}
 
 	return l, nil

internal/controller/pkg/revision/dependency.go

@@ -99,6 +99,8 @@ func (m *PackageDependencyManager) Resolve(ctx context.Context, meta pkgmetav1.P
 		case dep.Function != nil:
 			pdep.Package = *dep.Function
 			pdep.Type = ptr.To(v1beta1.FunctionPackageType)
+		default:
+			return 0, 0, 0, errors.Errorf("encountered an invalid dependency: package dependencies must specify either a valid type, or an explicit apiVersion, kind, and package")
 		}
 		pdep.Constraints = dep.Version
 		sources[i] = pdep