Drop stale "polls" wording, fix __version__ drift, add pre-release testing guidance - #15
Merged
Merged
Conversation
- pyproject.toml description and the package docstring said "polls" (the command was renamed poll -> export). Both feed user-facing surfaces (PyPI summary, `help(mt5_pnl_exporter)`). - __init__ hardcoded __version__ = "0.1.0" while the package is 1.0.0. Derive it from importlib.metadata so it tracks pyproject and can't drift again. - CONTRIBUTING.md: add "Testing changes before a release" — build+install the wheel on the Windows host for code changes; TestPyPI only for rehearsing publish mechanics (with its version-immutability and dependency-mirror caveats). The internal MT5 history-sync polling (_HISTORY_SYNC_POLL_S etc.) is a different, current mechanism and is left as-is. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup spotted after the
1.0.0release.pollswording (thepollcommand was renamed toexporton 2026-06-07):pyproject.tomldescription→ feeds the PyPI summary.src/mt5_pnl_exporter/__init__.pypackage docstring.gh repo edit.)__version__drift:__init__hardcoded"0.1.0"while the package is1.0.0. Now derived fromimportlib.metadata.version("mt5-pnl-exporter"), so it trackspyproject.tomland can't drift again.Left intentionally unchanged: the internal MT5 history-sync polling (
_HISTORY_SYNC_POLL_S,_HISTORY_SYNC_STABLE_POLLS) — a real, current mechanism, not the old command name.Test Plan
__version__resolves to1.0.0(dynamic)uv build,twine check --strictall pass locallyNote
The live PyPI
1.0.0summary and its baked-in__version__are immutable; these fixes apply to the next release. See PR discussion re: cutting1.0.1.🤖 Generated with Claude Code