Skip to content

release 2.4.4#620

Merged
tangcent merged 1 commit intomasterfrom
release/v2.4.4
Mar 17, 2026
Merged

release 2.4.4#620
tangcent merged 1 commit intomasterfrom
release/v2.4.4

Conversation

@tangcent
Copy link
Copy Markdown
Owner

@tangcent tangcent commented Mar 17, 2026

@qodo-code-review
Copy link
Copy Markdown

Review Summary by Qodo

Release version 2.4.4 with bug fixes

📦 Other

Grey Divider

Walkthroughs

Description
• Update plugin version from 2.4.3 to 2.4.4
• Document three bug fixes in changelog and release notes
• Fix shell interpretation in CI workflows, IconLoader compatibility, and MavenId binary
  incompatibility
Diagram
flowchart LR
  A["Version 2.4.3"] -- "Release 2.4.4" --> B["Updated Version"]
  B -- "Document Fixes" --> C["Changelog & Release Notes"]
  C -- "Three Bug Fixes" --> D["CI/Shell, IconLoader, MavenId"]
Loading

Grey Divider

File Changes

1. gradle.properties ⚙️ Configuration changes +1/-1

Update plugin version to 2.4.4

• Update plugin_version from 2.4.3.212.0 to 2.4.4.212.0

gradle.properties


2. idea-plugin/parts/pluginChanges.html 📝 Documentation +6/-2

Update plugin release notes for v2.4.4

• Update release tag link from v2.4.3 to v2.4.4
• Update release date from 2026-01-14 to 2026-03-17
• Replace single fix entry with three new bug fixes (#619, #618, #617/#1279)

idea-plugin/parts/pluginChanges.html


3. IDEA_CHANGELOG.md 📝 Documentation +6/-0

Add 2.4.4 release notes to changelog

• Add new 2.4.4 release section at top of changelog
• Document three bug fixes with PR references (#619, #618, #617)
• Maintain existing 2.4.3 changelog entry below

IDEA_CHANGELOG.md


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review bot commented Mar 17, 2026

Code Review by Qodo

🐞 Bugs (2) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Action required

1. Stale plugin.xml version 🐞 Bug ✓ Correctness
Description
The IntelliJ plugin descriptor still declares version 2.2.4.212.0 while the release/build version is
2.4.4.212.0, leaving the codebase with conflicting sources of truth for the plugin version. This can
lead to incorrect version reporting/verification and release packaging mistakes if the descriptor is
used as-is.
Code

gradle.properties[2]

+plugin_version=2.4.4.212.0
Evidence
The PR bumps the build/version property to 2.4.4.212.0, but the checked-in plugin descriptor still
hardcodes 2.2.4.212.0, and the Gradle patchPluginXml task is not configured in-repo to set/align the
plugin <version> value.

gradle.properties[1-6]
idea-plugin/src/main/resources/META-INF/plugin.xml[1-5]
idea-plugin/build.gradle.kts[117-124]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The repo declares the release/build version as `2.4.4.212.0` but `idea-plugin/src/main/resources/META-INF/plugin.xml` still hardcodes `&lt;version&gt;2.2.4.212.0&lt;/version&gt;`, and the in-repo Gradle configuration does not explicitly align/patch that value.

## Issue Context
This is a release PR; version inconsistencies in the plugin descriptor can cause incorrect version reporting and complicate release verification.

## Fix Focus Areas
- gradle.properties[1-3]
- idea-plugin/src/main/resources/META-INF/plugin.xml[1-6]
- idea-plugin/build.gradle.kts[117-124]

## Suggested change
- Prefer a single source of truth:
 - Either update `plugin.xml` `&lt;version&gt;` to match `plugin_version`, OR
 - Configure the Gradle IntelliJ patching step to explicitly set the plugin XML version from `project.version` (so future bumps don’t require manual edits).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Remediation recommended

2. Ambiguous PR references 🐞 Bug ✧ Quality
Description
The 2.4.4 change notes reference both #1279 and #617 for the same fix, and the HTML notes link #1279
to a pull URL while also showing (#617) as plain text. This makes the release notes ambiguous and
can send users to the wrong change discussion when auditing 2.4.4 fixes.
Code

idea-plugin/parts/pluginChanges.html[13]

+  <li>fix: use reflection to access MavenId to avoid binary incompatibility with IDEA 261+ (<a href="https://github.com/tangcent/easy-api/pull/1279">#1279</a>) (#617)</li>
Evidence
The in-IDE change notes contain two different identifiers for the same bullet and link only one of
them (to /pull/1279), while the markdown changelog links the change to PR #617, demonstrating
inconsistent references across release documentation.

idea-plugin/parts/pluginChanges.html[8-14]
IDEA_CHANGELOG.md[1-7]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Release notes for 2.4.4 reference both `#1279` and `#617` for the same fix, and `pluginChanges.html` links `#1279` to a PR URL while leaving `#617` unlinked. This is ambiguous and inconsistent with `IDEA_CHANGELOG.md`, which links the PR as `#617`.

## Issue Context
These files are used as user-facing release notes (in-IDE and in-repo). The same change should not point to two different identifiers unless clearly labeled (e.g., “Issue #… fixed by PR #…”).

## Fix Focus Areas
- idea-plugin/parts/pluginChanges.html[8-14]
- IDEA_CHANGELOG.md[1-7]

## Suggested change
- Decide what `#1279` represents (PR vs issue) and:
 - If it’s the PR: remove `#617` and keep/link `#1279`.
 - If it’s an issue: change the URL to `/issues/1279` (or label it as an issue) and link `#617` as the PR (or remove one reference).
- Ensure both files use the same convention.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@github-actions github-actions bot added the release release new version label Mar 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

📦 Plugin has been packaged for this PR. You can download easy-api-2.4.4.212.0.zip from the GitHub Actions workflow run by clicking on the "Artifacts" dropdown.

@@ -1,5 +1,5 @@
plugin_name=EasyApi
plugin_version=2.4.3.212.0
plugin_version=2.4.4.212.0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Stale plugin.xml version 🐞 Bug ✓ Correctness

The IntelliJ plugin descriptor still declares version 2.2.4.212.0 while the release/build version is
2.4.4.212.0, leaving the codebase with conflicting sources of truth for the plugin version. This can
lead to incorrect version reporting/verification and release packaging mistakes if the descriptor is
used as-is.
Agent Prompt
## Issue description
The repo declares the release/build version as `2.4.4.212.0` but `idea-plugin/src/main/resources/META-INF/plugin.xml` still hardcodes `<version>2.2.4.212.0</version>`, and the in-repo Gradle configuration does not explicitly align/patch that value.

## Issue Context
This is a release PR; version inconsistencies in the plugin descriptor can cause incorrect version reporting and complicate release verification.

## Fix Focus Areas
- gradle.properties[1-3]
- idea-plugin/src/main/resources/META-INF/plugin.xml[1-6]
- idea-plugin/build.gradle.kts[117-124]

## Suggested change
- Prefer a single source of truth:
  - Either update `plugin.xml` `<version>` to match `plugin_version`, OR
  - Configure the Gradle IntelliJ patching step to explicitly set the plugin XML version from `project.version` (so future bumps don’t require manual edits).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.983%. Comparing base (5b3cf94) to head (43717fc).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              master      #620   +/-   ##
===========================================
  Coverage     53.983%   53.983%           
  Complexity      2350      2350           
===========================================
  Files            259       259           
  Lines          13545     13545           
  Branches        3256      3256           
===========================================
  Hits            7312      7312           
  Misses          4788      4788           
  Partials        1445      1445           
Flag Coverage Δ
unittests 53.983% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b3cf94...43717fc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tangcent tangcent merged commit 86f0a31 into master Mar 17, 2026
15 checks passed
@tangcent tangcent deleted the release/v2.4.4 branch March 17, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release release new version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant