Merged
Conversation
LCOV of commit
|
drewstone
reviewed
Dec 18, 2024
drewstone
reviewed
Dec 18, 2024
drewstone
reviewed
Dec 18, 2024
cdb2a5b to
985037e
Compare
There was a problem hiding this comment.
Copilot reviewed 1 out of 10 changed files in this pull request and generated no comments.
Files not reviewed (9)
- src/AssetsLib.sol: Language not supported
- src/BlueprintServiceManagerBase.sol: Language not supported
- src/IBlueprintServiceManager.sol: Language not supported
- src/MasterBlueprintServiceManager.sol: Language not supported
- src/Permissions.sol: Language not supported
- src/ServiceOperatorsLib.sol: Language not supported
- test/BlueprintServiceManagerBase.t.sol: Language not supported
- test/Dummy.t.sol: Language not supported
- test/MockBlueprintServiceManager.sol: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the asset management system in the blockchain project. The main focus is the introduction of the
AssetsLib.sollibrary and the refactoring of theBlueprintServiceManagerBasecontract to utilize this new library. Additionally, some redundant code has been removed, and new utility functions have been added.Introduction of
AssetsLib.sollibrary:AssetsLib.solto handle asset types and conversions, including enums, structs, and utility functions for asset management.Refactoring to use
AssetsLib.sol:BlueprintServiceManagerBaseto use the newAssetslibrary for asset management, replacing the oldServiceOperatorslibrary. This includes changes to functions such as_permitAsset,_revokeAsset,_getPermittedAssets, and_isAssetPermitted. [1] [2] [3] [4] [5] [6] [7]Removal of redundant code:
ServiceOperatorslibrary fromIBlueprintServiceManager.soland replaced it with an import statement for the newServiceOperatorsLib.sol. [1] [2]Additional imports and utility usage:
MasterBlueprintServiceManager.solto support theAssetslibrary andSafeERC20for handling ERC20 tokens. [1] [2]These changes improve the modularity and readability of the codebase by centralizing asset management logic within a dedicated library.
Closes #24
Closes #16