added autoLaunchEnable setting #655
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement
This was a feature I wanted so I added it for myself, and I believe that many others would benefit from it. I find the most powerful part of Olauncher to be the search bar. It is total digital minimalism: I need my phone for something, an app or a search, so I swipe up and go. For people like myself, however, that use the search bar as much for web search as for app searches, the
autoLaunchfeature tends to do more harm than good.Current state of
autoLaunchEntering a
' 'character before your search disables theautoLaunch, but to know this you have to scroll decently far through the FAQs; and even armed with the knowledge, you have to remember it every time you want to do so. I'm sure many users of Olauncher have opened WhatsApp at a higher rate than usual thanks to this fact. For me, it's not worth the hassle, and I would rather disable theautoLaunchfeature entirely. If there's only one app left, it doesn't take any time or brain power to press it.What did I change?
For those like me who feel it is more hindrance than helper, I added a setting called "Auto launch app" which allows users to enable or disable the feature entirely. By default, "Auto launch app" is set to "On", and the behavior is exactly like before; you may start your search with a
' 'to disableautoLaunch, or else an application with launch automatically if it is the only app left in the filter. New: If you set "Auto launch app" to be "Off", an application will never launch from filter without you pressing it.To expose this setting, I noticed that it didn't fit cleanly into any of the pre-existing categories. It is not a "Home Screen" setting, nor "Appearance", nor "Gestures". As such, I introduced a new category, "Search", and pulled the "Auto Show Keyboard" setting into "Search". This change is not something I feel strongly about, but I do believe that it is the best arrangement that I tried.
What next?
I am filing this PR because I feel very strongly that it should be an option for users; if you want modifications, please feel free to ask. I don't plan on making other contributions, but I'd be happy to take on some Issues that you'd like to see implemented.