Support correlating logs with traces with Timbre OTLP appender#399
Closed
devurandom wants to merge 1 commit intotaoensso:masterfrom
Closed
Support correlating logs with traces with Timbre OTLP appender#399devurandom wants to merge 1 commit intotaoensso:masterfrom
devurandom wants to merge 1 commit intotaoensso:masterfrom
Conversation
Capture the OpenTelemetry context in a Timbre middleware and pick it up in the Timbre OTLP appender. This allows to correlate logs with traces. Fixes: f3ce2b5
devurandom
changed the title
ptaoussanis
pushed a commit
that referenced
this pull request
Aug 21, 2025
Member
|
@devurandom Thanks for this Dennis! I made a few changes at 080acff and have pushed for testing at https://clojars.org/com.taoensso/timbre/versions/6.8.0-SNAPSHOT Main change was to rename the context key to make it easier for folks to work with, if they choose to. If you have an opportunity, could you please confirm that this works as expected? If so, I'll aim to cut a new Timbre release later today or tomorrow 👍 |
Contributor
Author
|
Yes, 6.8.0-SNAPSHOT works. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture the OpenTelemetry context in a Timbre middleware and pick it
up in the Timbre OTLP appender. This allows to correlate logs with
traces.
Fixes: f3ce2b5