Skip to content

Conversation

@guanshengliang
Copy link
Contributor

Description

Issue(s)

  • Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @guanshengliang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates changes from the 3.3.8 release branch into the main branch. The primary focus of these changes is to enhance the documentation by centralizing release information and improving SQL example formatting. Additionally, it introduces significant functional improvements to the query executor, specifically enabling SLIMIT and OFFSET clauses to work correctly with GROUP BY operations, which is backed by expanded test coverage.

Highlights

  • Documentation Restructuring: Consolidated TDengine release history and versioning rules into a single, central documentation file, removing redundant pages for better organization.
  • SQL Documentation Improvements: Standardized SQL example formatting in basic insert documentation, including uppercase keywords, semicolons, and consistent indentation for enhanced clarity and readability.
  • Query Executor Enhancements for SLIMIT: Implemented robust support for SLIMIT and OFFSET clauses within GROUP BY operations in the query executor, providing more granular control over grouped result sets.
  • Expanded Test Coverage: Added new test cases to validate INSERT INTO ... SELECT behavior and extensively test the new SLIMIT functionality when combined with GROUP BY, UNION, and PARTITION BY queries, ensuring stability and correctness.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/new-framework-test.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request merges changes from a release branch, including documentation improvements, bug fixes, and new feature implementations. The documentation has been updated for better consistency and correctness in SQL examples. A key feature addition is the support for SLIMIT in GROUP BY queries, which appears to be well-implemented along with corresponding test cases. However, I've identified a critical issue in one of the test files where new test code has been misplaced, which will cause test failures. My review provides details on this issue.

Comment on lines +162 to +164
tdSql.execute(f"INSERT INTO ohlcv_1d(tbname,ts) SELECT '1.34' as tb, '2025-12-01T00:00:00.000-05:00' FROM ohlcv_1m WHERE symbol = 'AAPL' AND ts >= '2025-12-01T00:00:00.000' AND ts < '2025-12-02T00:00:00.000' PARTITION BY tbname, symbol;")
tdSql.error(f"INSERT INTO ohlcv_1d(tbname,ts) SELECT 1.34 as tb, '2025-12-01T00:00:00.000-05:00' FROM ohlcv_1m WHERE symbol = 'AAPL' AND ts >= '2025-12-01T00:00:00.000' AND ts < '2025-12-02T00:00:00.000' PARTITION BY tbname, symbol;")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These new test lines for ohlcv_1d and ohlcv_1m have been added to the Test2 method. However, these tables are created and used within the Test3 method, which operates on a different database (db3 vs db2). This will cause Test2 to fail as the tables do not exist in its context.

Furthermore, identical test lines are already present in Test3 (lines 207-208 in the full file). It seems these lines were added here by mistake and should be removed to prevent test failures.

@guanshengliang guanshengliang merged commit 2d05ff9 into main Jan 7, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants