-
Notifications
You must be signed in to change notification settings - Fork 5k
docs: add support for recording STMT to CSV files #34276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @huskar-t, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds documentation for a new feature in taosadapter that allows recording STMT operations to CSV files. The changes include adding a new configuration parameter, its corresponding environment variable, and a detailed section explaining the feature's configuration, dynamic control via HTTP API, and data format. The documentation has been updated in both English and Chinese versions.
My review focuses on the clarity and correctness of the new documentation. I've found several areas with copy-paste errors from the existing SQL logging documentation, which could lead to confusion. These include incorrect references to 'SQL' instead of 'STMT', a typo in a filename example, and vague descriptions. I've provided suggestions to correct these inconsistencies and improve clarity.
2ac6042 to
533bf5f
Compare
533bf5f to
54151fa
Compare
54151fa to
581090e
Compare
* docs: add support for recording STMT to CSV files * docs: update version for STMT recording feature in CSV files
resolve: https://project.feishu.cn/taosdata_td/feature/detail/6622887611 * docs: add support for recording STMT to CSV files * docs: update version for STMT recording feature in CSV files
Description
docs: add support for recording STMT to CSV files
Issue(s)
Checklist
Please check the items in the checklist if applicable.