docs: add maxSQLLength version in 3.3.8 #34543
Conversation
Summary of ChangesHello @Pengrongkun, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the accuracy of the project's documentation by updating the version information for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to update the documentation for the maxSQLLength parameter. While the change to the Chinese documentation correctly adds the new version, the English documentation incorrectly replaces the old version number, which could be misleading. I've provided suggestions to correct the English documentation and to slightly improve the clarity of the Chinese documentation.
| | smlDot2Underline | |Supported, effective immediately | Converts dots in supertable names to underscores in schemaless | | ||
| | maxInsertBatchRows | |Supported, effective immediately | Internal parameter, maximum number of rows per batch insert | | ||
| | maxSQLLength | v3.3.6.34 |Supported, effective immediately | Maximum length of a single SQL statement; default value: 1,048,576; minimum value: 1,048,576; maximum value: 67,108,864 | | ||
| | maxSQLLength | v3.3.8.8 |Supported, effective immediately | Maximum length of a single SQL statement; default value: 1,048,576; minimum value: 1,048,576; maximum value: 67,108,864 | |
There was a problem hiding this comment.
The update to the supported version is appreciated. However, replacing v3.3.6.34 with v3.3.8.8 removes important information. Based on the change in the Chinese documentation, this feature is available in both version streams. To avoid confusion for users, it would be best to list both versions.
| | maxSQLLength | v3.3.8.8 |Supported, effective immediately | Maximum length of a single SQL statement; default value: 1,048,576; minimum value: 1,048,576; maximum value: 67,108,864 | | |
| | maxSQLLength | v3.3.6.34, v3.3.8.8 |Supported, effective immediately | Maximum length of a single SQL statement; default value: 1,048,576; minimum value: 1,048,576; maximum value: 67,108,864 | |
| - 最大值：67108864 | ||
| - 动态修改：支持通过 SQL 修改，立即生效 | ||
| - 支持版本：从 v3.3.6.34 版本开始引入 | ||
| - 支持版本：从 v3.3.6.34 和 v3.3.8.8 版本开始引入 |
There was a problem hiding this comment.
For better clarity, consider using an enumeration comma (、) instead of 和 to list the versions. This makes it clearer that these are separate version streams where the feature was introduced.
| - 支持版本：从 v3.3.6.34 和 v3.3.8.8 版本开始引入 | |
| - 支持版本：从 v3.3.6.34、v3.3.8.8 版本开始引入 |
There was a problem hiding this comment.
Pull request overview
Updates taosc client configuration documentation to reflect the supported version(s) for the maxSQLLength parameter, aligning with the 3.3.8.8 release line.
Changes:
- Update
maxSQLLengthsupported version text in Chinese documentation to include v3.3.8.8. - Update
maxSQLLengthsupported version cell in English documentation (currently set to v3.3.8.8).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/zh/14-reference/01-components/02-taosc.md | Updates the maxSQLLength “supported version” line to include v3.3.8.8. |
| docs/en/14-reference/01-components/02-taosc.md | Updates the maxSQLLength supported version in the English parameter table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | smlDot2Underline | |Supported, effective immediately | Converts dots in supertable names to underscores in schemaless | | ||
| | maxInsertBatchRows | |Supported, effective immediately | Internal parameter, maximum number of rows per batch insert | | ||
| | maxSQLLength | v3.3.6.34 |Supported, effective immediately | Maximum length of a single SQL statement; default value: 1,048,576; minimum value: 1,048,576; maximum value: 67,108,864 | | ||
| | maxSQLLength | v3.3.8.8 |Supported, effective immediately | Maximum length of a single SQL statement; default value: 1,048,576; minimum value: 1,048,576; maximum value: 67,108,864 | |
There was a problem hiding this comment.
The "Supported Version" for maxSQLLength was changed from v3.3.6.34 to only v3.3.8.8, but the Chinese doc now states it was introduced in both v3.3.6.34 and v3.3.8.8. Please confirm the actual introduction versions and align the English row accordingly (e.g., list both versions if it exists in both release lines).
| | maxSQLLength | v3.3.8.8 |Supported, effective immediately | Maximum length of a single SQL statement; default value: 1,048,576; minimum value: 1,048,576; maximum value: 67,108,864 | | |
| | maxSQLLength | v3.3.6.34 / v3.3.8.8 |Supported, effective immediately | Maximum length of a single SQL statement; default value: 1,048,576; minimum value: 1,048,576; maximum value: 67,108,864 | |
| | smlDot2Underline | |Supported, effective immediately | Converts dots in supertable names to underscores in schemaless | | ||
| | maxInsertBatchRows | |Supported, effective immediately | Internal parameter, maximum number of rows per batch insert | | ||
| | maxSQLLength | v3.3.6.34 |Supported, effective immediately | Maximum length of a single SQL statement; default value: 1,048,576; minimum value: 1,048,576; maximum value: 67,108,864 | | ||
| | maxSQLLength | v3.3.8.8 |Supported, effective immediately | Maximum length of a single SQL statement; default value: 1,048,576; minimum value: 1,048,576; maximum value: 67,108,864 | |
There was a problem hiding this comment.
There appears to be an extra leading space in the maxSQLLength supported version cell (| v3.3.8.8), which can affect Markdown table alignment/rendering. Consider normalizing spacing to match surrounding rows.
| | maxSQLLength | v3.3.8.8 |Supported, effective immediately | Maximum length of a single SQL statement; default value: 1,048,576; minimum value: 1,048,576; maximum value: 67,108,864 | | |
| | maxSQLLength | v3.3.8.8 |Supported, effective immediately | Maximum length of a single SQL statement; default value: 1,048,576; minimum value: 1,048,576; maximum value: 67,108,864 | |
| - 最大值：67108864 | ||
| - 动态修改：支持通过 SQL 修改，立即生效 | ||
| - 支持版本：从 v3.3.6.34 版本开始引入 | ||
| - 支持版本：从 v3.3.6.34 和 v3.3.8.8 版本开始引入 |
There was a problem hiding this comment.
Using two versions with the phrasing “从 v3.3.6.34 和 v3.3.8.8 版本开始引入” is a bit ambiguous (it reads like a single introduction point). Consider clarifying that the parameter was introduced separately in two release lines (e.g., “分别从 … 开始引入” or “从 v3.3.6.34 / v3.3.8.8 开始引入”).
| - 支持版本：从 v3.3.6.34 和 v3.3.8.8 版本开始引入 | |
| - 支持版本：分别从 v3.3.6.34 和 v3.3.8.8 版本开始引入 |
Pengrongkun
force-pushed
the
docs/3.3.8/6788575563
branch
from
88066a4 to
f08afcc
Compare
3 participants
Description
Issue(s)
Checklist
Please check the items in the checklist if applicable.