Skip to content

fix: [6880760974] Open window cases.#34745

Merged
guanshengliang merged 1 commit intomainfrom
fix/main/6880760974
Mar 16, 2026
Merged

fix: [6880760974] Open window cases.#34745
guanshengliang merged 1 commit intomainfrom
fix/main/6880760974

Conversation

@Simon9997
Copy link
Contributor

@Simon9997 Simon9997 commented Mar 11, 2026

Description

在 196 上的测试结果:
截屏2026-03-16 08 14 55

Issue(s)

  • Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

Copilot AI review requested due to automatic review settings March 11, 2026 00:53
@Simon9997 Simon9997 requested a review from a team as a code owner March 11, 2026 00:53
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the test coverage for virtual tables by activating a large set of existing test cases in the CI pipeline. The change ensures that a wider range of virtual table functionalities, from basic operations to complex query scenarios, are regularly validated, thereby improving the overall stability and reliability of the virtual table feature.

Highlights

  • CI Test Case Expansion: Enabled a comprehensive suite of 43 new test cases related to Virtual Tables within the test/ci/win_cases.task configuration file. These cases cover various aspects of virtual table functionality, including alteration, authorization, creation, dropping, insertion, joining, metadata, query planning, and diverse query scenarios across different database and table types.
  • Virtual Table Testing: The newly activated tests specifically target the 05-VirtualTables directory, ensuring broader coverage and validation of virtual table operations and behaviors in the continuous integration pipeline.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • test/ci/win_cases.task
    • Added 43 new test cases for virtual tables to be run in the CI pipeline.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to “open” (enable) additional Windows CI test cases by adding a large set of VirtualTables pytest cases into a Windows task list.

Changes:

  • Added many cases/05-VirtualTables/*.py pytest entries to test/ci/win_cases.task.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables a large suite of virtual table test cases for the Windows CI build by adding them to win_cases.task. My review focuses on the maintainability of this list. I've suggested sorting the newly added test cases alphabetically to make the file easier to manage and to prevent accidental duplicates in the future.

Copilot AI review requested due to automatic review settings March 16, 2026 00:35
@Simon9997 Simon9997 force-pushed the fix/main/6880760974 branch from aded44e to f8ce5f2 Compare March 16, 2026 00:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@guanshengliang guanshengliang merged commit b3bbe48 into main Mar 16, 2026
13 of 15 checks passed
@guanshengliang guanshengliang deleted the fix/main/6880760974 branch March 16, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants