feat(xnode): support xnode feature on Windows platform

[acerDebugman]

Closes 6646294817

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive support for the xnode feature on the Windows platform. It adapts network communication, file path handling, and security token generation mechanisms to be compatible with Windows operating system conventions and APIs, ensuring the xnode functionality operates correctly across different environments.

Highlights

• Windows-specific Xnode URL: Defined a distinct XNODED_PIPE_SOCKET_URL for the Windows platform, setting it to "http://localhost:6051" while retaining "http://localhost" for other operating systems.
• Enabled cURL requests on Windows: Removed conditional compilation that previously disabled cURL functions for Windows, allowing taosCurlGetRequest, taosCurlPostRequest, and taosCurlDeleteRequest to be used. UNIX socket path options are now conditionally excluded on Windows.
• JWT Token Generation for Windows: Implemented Windows-specific logic for HMAC-SHA256, Base64 URL encoding, and the creation of JWT headers, payloads, and signatures, ensuring secure token generation on the platform.
• Windows Path Handling: Updated functions getXnodedPipeName and getXnodedPidPath to correctly handle file paths and path separators (/ vs \) on Windows, improving cross-platform compatibility.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• source/dnode/mnode/impl/src/mndXnode.c
  • Updated XNODED_PIPE_SOCKET_URL to include a Windows-specific definition.
  • Modified cURL request functions (taosCurlGetRequest, taosCurlPostRequest, taosCurlDeleteRequest) to conditionally exclude UNIX socket path options on Windows.
  • Removed the #else block that previously stubbed out cURL request functions for Windows.
  • Introduced Windows-specific implementations for HMAC-SHA256, Base64 URL encoding, and JWT token creation (mndXnodeCreateAgentToken).
  • Adjusted conditional compilation for agentTokenField struct and mndXnodeCreateAgentTokenField function.
  • Wrapped taosCheckExistFile call in mndSendReqRetJson with #ifndef WINDOWS.
• source/dnode/xnode/src/xnode.c
  • Refactored getXnodedPipeName to use Windows-specific path separators and conditional compilation for path formatting.
• source/libs/txnode/src/txnodeMgmt.c
  • Refactored getXnodedPidPath to use Windows-specific path separators and conditional compilation for path formatting.

Activity

• No specific activity (comments, reviews, progress) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for the xnode feature on the Windows platform. The changes primarily involve adapting the inter-process communication to use TCP sockets instead of Unix domain sockets on Windows, and providing platform-specific implementations for path handling and JWT token generation. My review highlights a few areas for improvement. A significant part of the change is a custom implementation of JWT generation for Windows, which introduces potential security and maintenance risks; I recommend exploring the use of a standard, cross-platform library. Additionally, I've identified some code duplication and complex conditional logic in path handling that could be simplified for better readability and maintainability, and I have provided suggestions for refactoring.