Skip to content

feat(taosgen): add command-line parameters for log output#34777

Open
YamingPei wants to merge 1 commit intomainfrom
docs/6751373446
Open

feat(taosgen): add command-line parameters for log output#34777
YamingPei wants to merge 1 commit intomainfrom
docs/6751373446

Conversation

@YamingPei
Copy link
Contributor

Description

Add command-line parameters for log output

Issue(s)

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

Copilot AI review requested due to automatic review settings March 13, 2026 10:18
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the taosgen tool by providing users with greater control over its logging behavior through new command-line parameters. Additionally, it refines the documentation for timestamp offset configurations, offering more granular time units for relative offsets. These changes improve both the usability and clarity of the taosgen tool.

Highlights

  • Log Output Parameters: Introduced new command-line options (-d/--log-dir and -f/--log-file) for the taosgen tool, allowing users to specify the log output directory and a complete log file path.
  • Timestamp Offset Units: Expanded the timestamp_offset configuration documentation for taosgen to include h (hour) and m (minute) units for relative time offsets, and clarified that M represents month (uppercase).

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • docs/en/14-reference/02-tools/11-taosgen.md
    • Added command-line parameters for log output.
    • Updated timestamp offset units in documentation.
  • docs/zh/14-reference/02-tools/11-taosgen.md
    • Added command-line parameters for log output (Chinese).
    • Updated timestamp offset units in documentation (Chinese).
Activity
  • No specific activity beyond the initial pull request creation has been recorded.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds -d/--log-dir and -f/--log-file command-line parameters for taosgen log output, and fixes documentation for timestamp offset time units (adding h/m units, clarifying M vs m).

Changes:

  • Added documentation for new --log-dir and --log-file CLI parameters
  • Fixed/expanded timestamp offset unit documentation to include hours (h) and minutes (m), clarifying M (month) vs m (minute)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
docs/zh/14-reference/02-tools/11-taosgen.md Chinese docs: new log params + timestamp unit fixes
docs/en/14-reference/02-tools/11-taosgen.md English docs: new log params + timestamp unit fixes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds command-line parameters for log output and also updates documentation for timestamp_offset. The changes are functionally correct. I have provided two comments on the English documentation. One suggests a wording improvement for better clarity on parameter precedence. The other points out the inclusion of an unrelated change in this PR, which is a practice to avoid for better maintainability and reviewability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants