feat(taosgen): add command-line parameters for log output#34777
feat(taosgen): add command-line parameters for log output#34777
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
Adds -d/--log-dir and -f/--log-file command-line parameters for taosgen log output, and fixes documentation for timestamp offset time units (adding h/m units, clarifying M vs m).
Changes:
- Added documentation for new
--log-dirand--log-fileCLI parameters - Fixed/expanded timestamp offset unit documentation to include hours (
h) and minutes (m), clarifyingM(month) vsm(minute)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/zh/14-reference/02-tools/11-taosgen.md | Chinese docs: new log params + timestamp unit fixes |
| docs/en/14-reference/02-tools/11-taosgen.md | English docs: new log params + timestamp unit fixes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds command-line parameters for log output and also updates documentation for timestamp_offset. The changes are functionally correct. I have provided two comments on the English documentation. One suggests a wording improvement for better clarity on parameter precedence. The other points out the inclusion of an unrelated change in this PR, which is a practice to avoid for better maintainability and reviewability.
Description
Add command-line parameters for log output
Issue(s)
Checklist
Please check the items in the checklist if applicable.