Make tokenization respect escaped quotes.#77
Open
hXtreme wants to merge 2 commits intotaoyds:masterfrom
Open
Conversation
Author
|
Please let me know if you have any questions or concerns about the pr. |
Author
|
Hi just pinging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: SQL usually use single quotes for strings but the old implementation allowed both single and double quoted string as well as a single quoted string to end with a double quote.
This implementation keeps this behavior but allows for quotes to be escaped.
For example strings like
"O\'Reilly"won't cause assertion failure and will be tokenized correctly.