Fix parsing of lazy TAPs and similar in _parse_tap_into_sections_raw #1
Open
volker-fr wants to merge 4 commits intotapper:masterfrom
Open
Fix parsing of lazy TAPs and similar in _parse_tap_into_sections_raw #1volker-fr wants to merge 4 commits intotapper:masterfrom
volker-fr wants to merge 4 commits intotapper:masterfrom
Conversation
…sues with lazy plans
…st line is its own section
…ocus on plans; bugfix2: workaround for prove regex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I rebuild the splitting of sections in _parse_tap_into_sections_raw to fix the issues with lazy plans.
The change breaks two tests: intap_archive_rhv7.tap and strange_tap_oprofile_explicit_sections.t One reasons why it fails is for example that before a section which should not be a section is counted as one. Therefore the size of the array is smaller. Later this also affects the position of a value.
I marked with TODO the parts which may need some review or future improvement.